[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Wed, 12 Nov 2025 08:58:29 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TM8/v1CzzK3nXKTbFWzQamZBiKvsRN+R/eiFMR1Z91Q=; b=uifBiWN8169Cz71O4HM7TlmSr9ITSzaTgt+XkwLI7qZ1z8KQd/zCHdF4zHI/19nkoLkS05UoR9VDy1yl8FS0p095hr8VGhY7+AhkKzs/padC7ly2eKTHgfWnfqpBe2OsfxSS05ayn71NJg2ZwLWp2C2lFsdwiEPnJiISqAsrF8PHudvwZzyv4RksovGxfATCO3gR4AY9766FZHqHboAmuhp8RRW/haPtDsaBhMpGEOLdOxjtTFexWHe5YxFJzWCkYjXoXZsPz1znnuag91cOo525rv02SikLjitD+rJibLkm/QMJq/PvlxBvcXsz00QOkJdD8UGgrXHD2sRWQF9rdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D3KwcBbeXcXlkHAHdF2vIWpmR1EFjKVqPmj13sv9rwUKCD2S2HmLAdkSMWwzzho84ZsUGWDTaJMy236Fpby55YLcTgDu7e204Hdq/42GAhzApoNxqUAjs2/vFT32HPZK67ZYW0lTyURXsav1KXn4VMN2vmI/5ZHHdDUKtno5IjmiiYtIEAP4n8ign7zsyIWGOMEXo+jAE/CnKimlK4jKgxIbkN31QMmd+C7nciHyr9z0SnVsBFEKCEjFm6t69OGFBwM+B2Z8LZBgVNe1OMr8Sc5+qoc2YmV9loUApx+LRp1AuvtB0aWVex055+SwwphLSYFKUGLsGMTgziD4e+/J6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "oleksii.kurochko@xxxxxxxxx" <oleksii.kurochko@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 12 Nov 2025 08:58:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-11-12T08:58:18.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcPCqOfEVt2Jk05kOchIzPOp9r0LTavU6AgBQtWvA=
- Thread-topic: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, October 30, 2025 8:44 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; oleksii.kurochko@xxxxxxxxx; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Bertrand
> Marquis <bertrand.marquis@xxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Roger Pau Monné <roger.pau@xxxxxxxxxx>; Shawn Anastasio
> <sanastasio@xxxxxxxxxxxxxxxxxxxxx>; Alistair Francis
> <alistair.francis@xxxxxxx>;
> Bob Eshleman <bobbyeshleman@xxxxxxxxx>; Connor Davis
> <connojdavis@xxxxxxxxx>; Tamas K Lengyel <tamas@xxxxxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with
> CONFIG_MGMT_HYPERCALLS
>
> On 13.10.2025 12:15, Penny Zheng wrote:
> > --- a/xen/arch/x86/mm/mem_sharing.c
> > +++ b/xen/arch/x86/mm/mem_sharing.c
> > @@ -1396,6 +1396,7 @@ int __mem_sharing_unshare_page(struct domain *d,
> > return rc;
> > }
> >
> > +#ifdef CONFIG_MGMT_HYPERCALLS
> > int relinquish_shared_pages(struct domain *d) {
> > int rc = 0;
> > @@ -1452,6 +1453,7 @@ int relinquish_shared_pages(struct domain *d)
> > p2m_unlock(p2m);
> > return rc;
> > }
> > +#endif /* CONFIG_MGMT_HYPERCALLS */
> >
> > static int range_share(struct domain *d, struct domain *cd,
> > struct mem_sharing_op_range *range)
>
> Is this necessary? Shouldn't MEM_SHARING as a whole become dependent upon
> MGMT_HYPERCALLS, then also covering XENMEM_sharing_op? (The same will
> already implicitly happen for MEM_PAGING, due to its VM_EVENT dependency.)
>
Yes, Since I didn't see VM_EVENT dependency for MEM_SHARING. I'm not 100% sure
that whether memory sharing feature is dependent on VM_EVENT. Also as I roughly
look through the codes in mm/mem_sharing.c, maybe only
mem_sharing_notify_enomem() utilizes vm event subsystem.
> Jan
|
