[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/8] arm/gic: Use static irqaction
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Wed, 12 Nov 2025 10:51:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4FxshkFkWOqZmPT//TbkNT6jPbFRsRNuCROPuKtzNAY=; b=KPfne4HO/C7co+vVmTq0MtrkhJjnx4uIpvZr7kGik02O4kJZ2F6GGIlZpmuO7lIE7EAOVub4izheem8qJHJSnWqXxlYGM4doI6cvEbXXLlVSjQcoRQ9QWNUg/7PyFofAJ1PvCcW2Cpjp5qoYtqyQ4CPfLnhljA1cs4AlythO2SI7KRKJvPpFM1AwdLqB/WD9ZDq2d8kLSYUWIR2Ofo19RORCy0ehtTqmmHI3wLkzwmX9iAi2LLITFg84gcRTGD820qmWjp5e+lNnaMQeB/a9gvhWegLCzw4o5mg2FNKaTzz3+ccV0W+sTTfW/PlkrEv7Rg0MedxFDepwcWCZNx1NzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QU/E6D/VLWvTbrcom6n2/JUvZDwsJgd6kK2n4+lKTHmpUdkBrFU4wF5GciPKSsrpTLZe8PeD1xMhQyf4Qtg4IMa3bzkhlSDj+SoOdAe8vKGddMEIl+3wuJr40g6X1F7DSlLyn5yUfCrHpZaepZuvgUIKP2kEpvoKLXkCDbIQp9mExp/DA4KXSskNDhjX/pL/5sicG7+ELw2IBmUA+Q6UJqz2CSnz8VAmzUitsVZHjFt+KxWDdApWYoSi3iPO1DJ4rv9BWY0y1EZmVOV1Nlv3VrXCpjiOD8u3UOs8+xeO2VwZZIpGP8DH2f3fohd3X4JH5jCoDvjVdIMfLHPw/yPdyw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykola Kvach <Mykola_Kvach@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Wed, 12 Nov 2025 10:51:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcU8JXITHNd+O1aUapS4pb98alZA==
- Thread-topic: [PATCH v4 2/8] arm/gic: Use static irqaction
When stopping a core cpu_gic_callback is called in non-alloc
context, which causes xfree in release_irq to fail an assert.
To fix this, switch to a statically allocated irqaction that does not
need to be freed in release_irq.
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
Reviewed-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
v3->v4:
* make irqactions static
* collect RBs
v2->v3:
* no changes
v1->v2:
* use percpu actions
---
xen/arch/arm/gic.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 260ee64cca..ee75258fc3 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -386,10 +386,17 @@ void gic_dump_info(struct vcpu *v)
gic_hw_ops->dump_state(v);
}
+static DEFINE_PER_CPU_READ_MOSTLY(struct irqaction, irq_maintenance);
+
void init_maintenance_interrupt(void)
{
- request_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance_interrupt,
- "irq-maintenance", NULL);
+ struct irqaction *maintenance = &this_cpu(irq_maintenance);
+
+ maintenance->name = "irq-maintenance";
+ maintenance->handler = maintenance_interrupt;
+ maintenance->dev_id = NULL;
+ maintenance->free_on_release = 0;
+ setup_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance);
}
int gic_make_hwdom_dt_node(const struct domain *d,
--
2.51.2
|
