[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Thu, 13 Nov 2025 04:40:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=flpKEo+6p4kKoWbZSNSUB7qhP02KSIoHgKhxRIxqGgU=; b=ZyZ/+jDpvU8cd4bZ2jcuOrgOJzXUfcaOwGSVFArCiLXDsAe6P06Xgtktb14degM+2/kwBw2ajlGKGGKw8K0dsR1OBFWSoO8qSQwYPbMB41v6xkU+3Bb9KGDJv9C0OvgRn0VFQ7kKrJNsX3TUq1E1fspo9tpX7n+w/u39bQWyltGoEjCmijIUewpxyFaPwOWX6FXkoeCgSDmph1Xqb/hIpsu+fii2Vyto27QtqFycKmxhO4oCksbhVyh1EZ8zOwKPwwor3g1w/aeqGCWFdY6K+FpYMfaM0yzU4koz2d8Z9CAJ0AR4s4a5w/mFmB5GF+1RReNjVpVL1zYcrWLOb431dw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hQSUXrPs/TNqq4X2krFwKD0RzO2JtB8wusqMzF0qDc02sHDLltewy8TVeceRKYQtibCOlvWLa2DRgVfb4GtN4ozXLZDwpAbcOqEgwCe4WRWWg5NY2u6t5uSamtwzanE81g0kMqWJoFtOWkSL64cF6Kuy5ixiW70ttJKi5EYZvZAXFi6pfYlvsiccCnADnceXRGZewlEfqngqMRcKTXrrEnMuCvuLxQxNYiw5kEIHq2Qbhf++35WyBA330cRuFRXhQbNWygyvSFAXi6SZKxEaZfs40K/XoA215fmBDbkgEymuMTwYcMzlLmwAOObztZaQx9IOwwZfepIAdFevofgVlw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "oleksii.kurochko@xxxxxxxxx" <oleksii.kurochko@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 13 Nov 2025 04:40:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-11-13T04:39:44.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcPCqOfEVt2Jk05kOchIzPOp9r0LTavU6AgBVxtTA=
- Thread-topic: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, October 30, 2025 8:44 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; oleksii.kurochko@xxxxxxxxx; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Bertrand
> Marquis <bertrand.marquis@xxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Roger Pau Monné <roger.pau@xxxxxxxxxx>; Shawn Anastasio
> <sanastasio@xxxxxxxxxxxxxxxxxxxxx>; Alistair Francis
> <alistair.francis@xxxxxxx>;
> Bob Eshleman <bobbyeshleman@xxxxxxxxx>; Connor Davis
> <connojdavis@xxxxxxxxx>; Tamas K Lengyel <tamas@xxxxxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 15/28] xen/domctl: wrap domain_kill() with
> CONFIG_MGMT_HYPERCALLS
>
> > --- a/xen/arch/x86/mm/paging.c
> > +++ b/xen/arch/x86/mm/paging.c
> > @@ -768,6 +768,7 @@ void paging_vcpu_teardown(struct vcpu *v)
> > shadow_vcpu_teardown(v);
> > }
> >
> > +#ifdef CONFIG_MGMT_HYPERCALLS
> > /* Call when destroying a domain */
> > int paging_teardown(struct domain *d) { @@ -794,6 +795,7 @@ int
> > paging_teardown(struct domain *d)
> >
> > return rc;
> > }
> > +#endif /* CONFIG_MGMT_HYPERCALLS */
> >
> > /* Call once all of the references to the domain have gone away */
> > void paging_final_teardown(struct domain *d)
>
> This is irritating, and could hence have done with some clarification in the
> description (to aid review, if nothing else): On the surface, why would
> paging_teardown() need excluding, but paging_vcpu_teardown() and
> paging_final_teardown() would (need to) stay? Yes, the latter two are used on
> failure
> paths of certain functions. (Same e.g. for domain_teardown() and hence
> arch_domain_teardown().)
>
The reason for domain_teardown() is that its another usage is in the failure
path of domain_create()
The exclusion of paging_final_teardown() is blocked by domain_destroy(), which
will be triggered when refcnt equals zero.
> Jan
|
