[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86: Remove stubs from asm/pv/domain.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 13 Nov 2025 13:23:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKd15oiT6H5dSlMAOW634YLWGGRVLgxhDzHb0E2eXB4=; b=xzZrkOaCxkUWJ8RX7DlgKMWZkQMZsPA24sgVIJo7rSVTN4P8KEpXEwGFJ7UpDzcYxKzLivg+R4sQ8NOnBzE0MkOdkdz2Qj5CrP2FWnBhYVJR04g+FM/cafq62aU5gVnaJ3oN/IcrjctjV6HkYxC0COG5TV4apZfUQVEG6GJU7elU3XZyjtpct9CRV2eX4BZaoOCdDVC/bQVEp5spFxORvpYs07davQz9Lv6jsHpeK371Uf5PT/0r2Gctmex4WEWcP29gMuNztG7G5QR+eeR0FbDvqZKwZQ9jSmmr4mGU18gBVE8eV4fRlI3J+b7P8bSKg2M7bcEPUmBGPp6IgobzvA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x2cX45hUUsFORe5h3WyRbGdEikmQdtQjFfMnQQ/yC/mDOC8O6F1gFZNyKAnrXOJNQgUXThIHDhyeg7OqnOc+nPZJv8Mer2nHsfkofTVv2XUrHymKg+iLa3F03KjD6MTIgwG8JUH7hS39hOqqTXaclS4gc1Y+HunKyJuTcUsfs6fv+OZVehUON6UuIkNoSegU2J2juFBS8YuRZqjGDhQisrk9yNVQxMCN/vTjKHdflqTTViiRL1j5bf0RjoBEK6TQ8SoHsiS/aNQiqrGdcN6sCbVALgnf1VLPP+umrYDFiDuwLViaCeRf83pbY4FvfAdyDHHJ44wjgddU6K5c/q4jYg==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 13 Nov 2025 12:23:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Nov 13, 2025 at 12:50 PM CET, Jan Beulich wrote:
> On 12.11.2025 16:22, Alejandro Vallejo wrote:
>> They are unnecessary. The only two cases with link-time failures are
>> fallback else branches that can just as well be adjusted with explicit
>> IS_ENABLED(CONFIG_PV). HVM has no equivalent stubs and there's no reason
>> to keep the asymmetry.
>>
>> No functional change.
>>
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
>> ---
>> I'd rather remove the "rc = -EOPNOTSUPP" branch altogether, or replace
>> it with ASSERT_UNREACHABLE(), but I kept it here to preserve prior behaviour.
>>
>> Thoughts?
>
> I think using ASSERT_UNREACHABLE() there would be better, in particular bring
> things in line with the {hvm,pv}_domain_initialise() call site. Preferably
> that way (happy to adjust while committing):
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
Sounds good to me. Though arguablt the commit message might need to change too
to remove the last line about not being a functional change. While not
externally visible, it is a real change.
Cheers,
Alejandro
|
