[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 03/16] emul/ns16x50: implement emulator stub
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: dmukhin@xxxxxxxx
- Date: Thu, 13 Nov 2025 21:19:17 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/caTaloZJgx3jVoA4sILw4FgJsrBBRPJ1tCswcDbuH8=; b=QTMLOkiUtW0ZSPj3PMiV7negcDFnDvPXWRgUFL0FXRa17BWTk8egnWu5bqwXdO0Mf4VbC97mKj+wIjmZUGAq4h22bweROMNEpeSKrAZe5Arowj8uztJYSHVTgTrpe7wDYbYnaa6LpusYwMA8SRWgFpJhBQjFOnIAJfRcXMC9EWFrx1RiAd5t5A2d6l9lmA+Bavc8ybMVUtLfPH6Gyb/dsOeyq7VOdB7wpUZzdjdR4xQG5+FwkU6yroxeN6t/FtZWDJrWhzk25hUqMqOzhQOgOwxyLdcWbqW/8sANsymO1olneZV1uMyAzXJnmJBLxZro9P+o7a+sioidI40ujIimIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QeZ8oarRBcEh3F9aan8r89mfbEIYbWT6HvhLUXEj31QX/m03RuYts3qopHy5hqnpaUpvO5dE2bA2GI9xFi/BnoddFZMVIR51sgnM5AhGNEJqPbTBKuGVPV0rgXBOVF4nvMQniNtNtSet9VsR2Pq7KaUQ+G1FD5hC1+6sC4bifTI3WPJRjH8sjrMkgO6bdAQOJ8aMlCGPJO8I9C4iNIExEeTXhcIhHJ5Rr0pWw0mN4wsnxIr0+xPTtzHi2hcX28gSkA5TE2RP35SL32OLWGlBltNX2myIHfK6Yy87DeN9l2+6EIuaE2szuPiwFTBl2v8WdXoymv/eVdfRqHwaYx63Pw==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Fri, 14 Nov 2025 05:19:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
Hi Mykola,
Thanks for the earlier reviews!
I am getting back to that series.
On Wed, Sep 10, 2025 at 01:05:13PM +0300, Mykola Kvach wrote:
> Hi Denis,
>
> I appreciate you addressing the comments from the earlier version
> of the patch series.
>
> On Tue, Sep 9, 2025 at 12:12 AM <dmukhin@xxxxxxx> wrote:
> >
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > The change is the first on the way on introducing minimally functional
> > NS16550-compatible UART emulator.
> >
> > Only one domain, defined via 'vuart=' parameter, will have UART emulator
> > initially. The command line option is not documented yet because of the plan
> > to adjust this code for vUART configuration via xl.
>
> Since the command line option is not yet documented, it would be
> helpful to include the expected format of the 'vuart=' parameter in
> the commit message. This will make it easier for reviewers and future
> readers to understand how to use the option.
So I ended up moving that code into vuart.c where it belongs, along with
addressing all your feedback.
--
Denis
|
