[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] docs: replace @xxx@ markers at build time


  • To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 14 Nov 2025 11:40:30 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W19MrCDoPbtirXsMWA1QzvxUL8kXqHyIggKzu+m6Jxc=; b=KS0WYVHAsp+mEuleYVPCFyu7tR0NuILCajZ0Ia1zXtKAIEOj8bCEf16WSTaai8kD4qTsAEsDuBnNz2bjdKPW96+BXBU8kR0yIevwazdf9DDYALCFcg9UInpKfkkiFA3p948qQGnF+8WPVjkoziNaI6kSSR5BGPqWNCXgyrPmKA8HDwgWzZzvY76jSfi5hCvzSdLIo6DUg+yzs9mxcUQNTbURLGvC2mN/oe+5nUrDpJ8whgov/K4fXzU/EoARrfRd0pf5zpsgvbqIcm+anLgjatPpZ472hprOKojwNTmZrt4ND8h/hLObldNIa4uNCRfQHAg3suhkijJ+8EKywYzDxQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h3O4YUSnaSLqmfqzJV/kwBekOrxS04JMehtE3XmNGy05hPjEfzk1rmewtcPTE2BVk59jPRrXkpr7NRIMqBZ2FvD3CiXgPo9qcl4vAqD5c6JudV44sOfdgJwyY/8X7ZRWnIhRMYSlCho+xioO5RzCufKicC66vpP/pBpUaVv/+PjTg6zoQc4578d/SPuJ1FSm0rFuw2VGR5spw0Nr//e21TqnqubfPVxlkIFBrEQ58oZQmxtAhOmKyoPxTMly/yHzBxgZIBcgVux/xH1ncREWdXtdJ8K74JYDN+vZ9QwXTUatwiStXWOOtGQ3gSe9Dkv8AyX59QoAGcU9l1imIk1qmg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Nov 2025 11:40:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/11/2025 11:32 am, Juergen Gross wrote:
> diff --git a/docs/Makefile b/docs/Makefile
> index 37776d303c..e5f4a8ca86 100644
> --- a/docs/Makefile
> +++ b/docs/Makefile
> @@ -8,8 +8,11 @@ DATE         := $(call date,"+%Y-%m-%d")
>  DOC_ARCHES      := arm ppc riscv x86_32 x86_64
>  MAN_SECTIONS    := 1 5 7 8
>  
> +IN_FILES := man/xl-disk-configuration.5.pod 
> man/xl-network-configuration.5.pod
> +IN_FILES += man/xl.1.pod man/xl.cfg.5.pod man/xl.conf.5.pod

Sorry, I meant to say this on the previous revision.  Can we please list
these one per line, for the future ease of inserting/removing.

Is IN_FILES really correct?  These are the generated (non-.in) files,
rather than the .in files themselves.  GEN_FILES from v1 would seem to
be a better fit.

But, overall I think this is a nicer change.

> +
>  # Documentation sources to build
> -MAN-SRC-y := $(sort $(basename $(wildcard man/*.pod man/*.pandoc)))
> +MAN-SRC-y := $(sort $(basename $(wildcard man/*.pod man/*.pandoc) 
> $(IN_FILES)))

Doesn't the man/*.pod wildcard do this already ?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.