[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen/mm: reject XENMEM_claim_pages when using LLC coloring
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 24 Dec 2025 21:51:23 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAYQp2jY0c2ffDuovH+vVpGvWCzGf1gztqyf7C9P4NM=; b=rQ1CUAmt3svudWNrqTAxKzWvImXjOqD07yZ1a+Oy8HJy7K0AYdKeaB73T+gZqUs+0JneEJjaWwWeSkKay3bBV0MWoMzpNZrDVKzXo11RfA9iV4kKzngrHcs4AgEJpOp5KB/29zejn0uLggELX5jz5kBzcliDlfmGelgOLJqj4KdoNWbcUKRvP724oPzWz/GesJXaBFysgHn56RnHlJEQ7hwLYnV1uMO5hzeQMDP2bJCShEykXXGgoUsbhHKrkdCR/R1e2ViI7blEOXUy1uaVZ7Hv4zt/hudYJMyH1tNAeSfNoTLuUQp+PDw4JAER2Z4wGud4OTW+znKL8Ln3T9asqQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j7J84sBHTnj8P1Uq60qgbGUVT7FpOiRSAFwnSU9zRlwGi88TcTwJW8KslT9bxz5p0hgUnc0TC5Luo1YE5k+9a/zLba4EJbQJ+bwrnZUrMRNyLtRDVqNWCoxbkDCrqC93lw5p1PIDtDWxNsiYIkTt3cp/va/h2CrrmzHkLS3JQ0vHV6TDuMA4WddtjDxV8y9ixz/NM+xWRQ7aP9CCfSne74t2AxDoGiM45d+QCBY4rloY5lar/PJdD/etEnsPcvwAFihIF05NKI8JCDdEJ4syO9hy08b6DiDoYX6FdRrFxcNBF0Az/hZXYVYTVqU2HDRowyLP3s1BTVl7b16J1Qyl1A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 24 Dec 2025 21:51:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/12/2025 8:33 pm, Andrew Cooper wrote:
> On 24/12/2025 7:40 pm, Roger Pau Monne wrote:
>> The coloring allocator ignores claims, reject the usage of the hypercall if
> Minor grammar nit. You want a semicolon here rather than a comma.
>
>> LLC coloring is enabled. Note that the usage of alloc_color_heap_page() is
>> selected at boot time, and it's a system wide decision. Once enabled all
>> domains will use alloc_color_heap_page() for allocations, which ignores any
>> outstanding claims.
>>
>> The hypercall can be enabled if/when LLC coloring is adjusted to support
>> claims.
>>
>> Fixes: 95debe51a936 ("xen: add cache coloring allocator for domains")
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
With whatever config I've got lying around, this doesn't compile. It needs
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 3d978227276a..10becf7c1f4c 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -16,6 +16,7 @@
#include <xen/iocap.h>
#include <xen/ioreq.h>
#include <xen/lib.h>
+#include <xen/llc-coloring.h>
#include <xen/mem_access.h>
#include <xen/mm.h>
#include <xen/numa.h>
added.
~Andrew
|
