[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] xen/tools: fix grep reporting 'illegal byte sequence' in check-endbr.sh
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 11 Feb 2026 11:10:08 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=citrix.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mqrd7dHyMuoz1ErKCQtcjAj5O9dkGWF9TMNVvZy/hvM=; b=MJeT4STwKQ3sloMT3I2nI1d2asdAjiAi32gd+7MoZvLFvGhSECY60fvwHVDs/a9YTS1tOX6G6IZSgMh+7ct3e6LXdtiDfFDuW2vbKm7MBsRw44iwlwLHAqX5Eyxg6fanDP2zcDExCMvn34+nNGBJAFAO5NKAyLKMzTqIkWO3ps5sEAfJOM9++OnYVyyepeqbibVidbeR8vSgZ50IxhCeUxPNs6bbY1oWnalFiDhh4t8TuHkW2r05gwBGDYOSO4ZBmPJE9go1lznH2U+q/s1UQiM5JVAk+UkkjS7I67862CodnEePdF0AJ8XDIpWp5UzqR0OA/TM/609ik5mo9HbR/Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mqrd7dHyMuoz1ErKCQtcjAj5O9dkGWF9TMNVvZy/hvM=; b=IpvbUU+/L9iE4WPW4jqL5Q9n0Cma6y2v7MXtUrG6pYMpqh7RK1ba+s9w+psO35tSL9C063pGBKscEI0yaodfzgXL9MQrFqlV87OYXeu5lxzWqb5P2e2q9VZlKoslnL47R4lmtI3H9NyxDOrJAVPylpbBtM21g0mozGJvLy/f4xzzTMvavwhNpp70Co3gwge0v+RHQtcFCEeTKH6RXXNRQhre+CyTBC3tGxqTaimwMA8gGUrdDJIL4bnUDXHuJJioWhobCPesffnhBuBZplk1ZeI1SGV18oK+M0+F6JWchUNbPbGEwFZWCGKke1bdXeZ1KwAev5I4W0OSMjRzVqL45w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=yQUQZxC1wIbZ3ki83efr98N7dMlRi/K45JT4Ok1hhR7LLhuP+fwIeqo1As9b+G4TC3FaNRRbJyJssToUG+GcNqf3zGrQf6MYsCI428qRXiQRuqNhvlY+JlgeWcKE7Fbr4znZioeg2JIr8IJ1eaOucW/a/PkQiBtV7pKOZSujIrGx2GtxmgoTL8sRUQvpCYPm8E2BhQjGGoqFY+N5AYWFoUO5TktGJkppiK+NMTaHVmOeede6Vf853FjI1cwvAdzueMzw99WXZiam+sfgVL7W2wEKeRggqNdRAM1ogT7WpI5bQ/BpjIcJGDlxaBYuXsGRSuPNxJZF6XwElqNlzlyE+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M6nQwDGPgZJMNi3qBlEFRYCk9HHGUxVtyZQp7CcoICKDN9jWvBoLRKszGtA90ol9z5wqoQ0GxelQXLb9hFCl6z1uxlqVRZsP0xP6IDrFNeTjvuSGSGeo/yc9lTug2+YEMRee0iXDb7QOdtYlfoGOV3xXSeGnB11FoWICaovLrGVj2wftCKPuIN6OTy9zkhXxVa/0F5s/Qd3eNx5WxVSNC+faxRIdRwlkgfpp/wOSSElOzlFQNwbjGg/V+G2tgA3RxW56BtM6qBZO3QTPERzoB2ID2yHM7sQTCYyebYoJBvqnAay2fsKbcR6vUGPlJWLw63rRaZ0BggjdEB2aMX/xOA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 11 Feb 2026 11:11:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcm0PFx+m8d43xIkWteImzrRY3yLV9V2MA
- Thread-topic: [PATCH 3/5] xen/tools: fix grep reporting 'illegal byte sequence' in check-endbr.sh
Hi Roger,
> On 11 Feb 2026, at 11:46, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>
> On macOS the default encoding is UTF-8. The binary encoding used by the
> grep matching pattern is not valid when processed as UTF-8. Switch the
> local to C just for the grep invocation to use the binary match pattern
> correctly.
>
> Suggested-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Works and makes sense.
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/tools/check-endbr.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh
> index 383d7e710a53..0be9986dd356 100755
> --- a/xen/tools/check-endbr.sh
> +++ b/xen/tools/check-endbr.sh
> @@ -109,8 +109,9 @@ if $perl_re
> then
> LC_ALL=C grep -aobP '\xf3\x0f\x1e(\xfa|\xfb)|\x66\x0f\x1f\x01' $TEXT_BIN
> else
> - grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf
> '\363\17\36\373')" \
> - -e "$(printf '\146\17\37\1')" $TEXT_BIN
> + LC_ALL=C grep -aob -e "$(printf '\363\17\36\372')" \
> + -e "$(printf '\363\17\36\373')" \
> + -e "$(printf '\146\17\37\1')" $TEXT_BIN
> fi | $AWK -F':' '{printf "%s%07x\n", "'$vma_hi'", int('$((0x$vma_lo))') +
> $1}' > $ALL
>
> # Wait for $VALID to become complete
> --
> 2.51.0
>
|
