[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] xen/x86: always consider '/' as a division in assembly
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 11 Feb 2026 12:22:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQZW8Xc8JjdHLtma+EsAndH3CmHFXSp1Ru2UaiqBp0A=; b=TWstfIWiP7CeUBINJXq3bTyYet38uLMJuwr5eB+9MhH3e4b3cqBYRE5nMAj7O25z97KDopTM/3v4Ki7/PTO4wkaDqRlirfMrGc4isjQ7YWRKKYJe/mOJ9gLia1wCIXVm6OYsIrfbA6Esr3c+XD23mhzp959umImLQayfn6Dy0GX1+jEMqL1wP7Hn24qiskId97FklTuXkrYloeq5oznkccAiGZHlXMCGBFx4B8eNx6sCTzGR30epj5exCwDCgk5arYvV19orUxHBK44Q6hN7e9n6DwkwxNGrBdvWcoMYQ2C+zx3t3ZhrTuxehcApGh6lZX0pe0aZCJ2u5tOqNESWRA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l+Y2Aus9DfQz3W/uzdIPfzGNQkJ/TmN0oGpDS5kqv5llyv+t029ZoedI4q6Zsy50piKFg36sa6sqTydoclni18Khx2GsY0V1D/jLpnGr/WlSZ6kEf9H5/1fm5yu5Hnh2OeY4WJhpR624QCI/3b/2jIWtB7erF/gXylF9gxTHsG2SlLcxnXkFWRu4bDT2SLJqxmJ959eWIjBA0Dthb+Bn0mNid8mduhxHO8YQdJPciZWpIihfciJVFYPn12Rl/QOFJIs+HGni8jXb8y0mNBMOR+43V95GU1Zi70zExULXyLohSZRPEwYznJekYgIxpJBGzgTdRcdUwIsMPxSmibRt+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 11 Feb 2026 11:23:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 11, 2026 at 12:11:32PM +0100, Jan Beulich wrote:
> On 11.02.2026 11:46, Roger Pau Monne wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -413,6 +413,13 @@ ifneq ($(CONFIG_CC_IS_CLANG),y)
> > CFLAGS += -Wa,--strip-local-absolute
> > endif
> >
> > +ifeq ($(CONFIG_X86),y)
> > +# The GNU assembler will interpret '/' as a comment start marker instead
> > of a
> > +# divide for some ELF targets. Pass --divide when when available to
> > signal '/'
> > +# is always used as an operator in assembly.
> > +$(call cc-option-add,CFLAGS,CC,-Wa$$(comma)--divide)
> > +endif
>
> As said before, I don't think this should be put here. Not even with the
> new ifeq(,) around it. It should go in x86/arch.mk, or a reason should be
> given why it can't.
My bad. I've attempted to put it there but got complains from the
build in x86/boot/. I think that was because I had leftover stale
objects in there, and nothing do to with the patch itself. I can
confirm it works when the chunk is placed in x86/arch.mk.
Thanks, Roger.
|
