[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Put wait.c behind CONFIG_WAIT
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 11 Feb 2026 17:30:02 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvRxHCINeB4XDe+8d5WxbCNOUpRrpeTIRs5E9YuaGlI=; b=ibN4zLMo50C2fMWNOOtWg3kyR6LAOLdKouCjJTaS2YiFewWg60n5q9kZ9L8ZULUg/PAG2ONrjXdDEar0VMTOsqFUoIu8dKFPnja3xcMOpaiKVVPa4aUk0atKrYfok/E8F+70AcbcS1fm4Scm1ghMqCP6KDy3I8O373OskXLft7Y0LsSh8Y+ckl/QSE4J4O6ozgkCfJ/I5YTvmPPrg0K27LA7z/pLGNCtAMxz1wQLLH90iW56AB6QWT5cIAkgIv9FXvpNESDO9oRDsDbUnzin2+k7ci/RmEo/PnjEbyzQDU8kTTwhB/MzRvLL0y30+aAdHQEuvQhk9QVKnt42gVcUgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V6UTkI0D9ta533DQr0MbijxhH1QbeVV8i3TLvWwtSJpI0QjxsfR6LLwHkNLOYJFy/ClSWb3CE/xIQAHMczp6rX2rr0d8K2GWfdB8yqOZNL1D7VVfd0EeiV+KuRosY+GPggtxeQWeDFtp9tFfW7glGaOBMoSINPJ3w7iDb4hHX0kfeYKneWPzkI9AsyFPBrsOu1Z/SRmso95ljRJI1sJvgS2Fw5DdhgNZsPPWZ2Y5VWCRGjVK+xiRSwJEOvM5M9WsneAHIJxRPvb2Ye/p3X3RkV3brFKaq5uj0tP2OQ2FSbkEbSCYICbQLT2o0ryrld2p73DCAlUXNtSjcEUeF3us0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 11 Feb 2026 17:30:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/02/2026 5:01 pm, Jason Andryuk wrote:
> wait.c is only used by vm_event.c. Make CONFIG_VM_EVENT select
> CONFIG_WAIT, and use CONFIG_WAIT to control building it.
>
> Provide stubs of functions called from common code. entry.S needs an
> ifdef to hide the symbol from the assembly.
>
> Also conditionalize .waitqueue_vcpu in struct vcpu to save space.
>
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
I'd really rather see the API/ABI changes required to purge wait.c
entirely, but I guess this will do in the short term.
Two things want further thought.
First, because ARM uses per-vCPU stacks not per-pCPU stacks, it doesn't
need this infrastructure in the first place, but it looks like it's
still compiled in and half wired up. I suppose you don't notice because
you compile out VM_EVENT on ARM too?
Second CONFIG_WAIT isn't great name because there are many things it
could be. I'd be tempted to just reuse CONFIG_VM_EVENT and go without
CONFIG_WAIT. I do not want to see any new users of wait.c, and it will
disappear at some point.
~Andrew
|
