[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/6] xen/console: promote conring{,_size} to __ro_after_init
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: dmukhin@xxxxxxxx
- Date: Wed, 11 Feb 2026 11:47:47 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Fc7YYKQH/W+qCuZFYaTeuymKyeTP2jh3pYNCJSfMnE=; b=q6OjOMOXf5mx4wfeMXTSijCJtDZmqWZTZ4J55hOcTmLWbvuFT5qo5KxG6M3daDMb1r0sI2UwAKvY+sUCopuM9G9WmZOyZFtEDJn3TY6xOMFSbsk/SVJNF8BOhgOPbqIf/8mSFJrKykO8yIJFl8Y6XtrNjBP0Lel8iLt6GguzABjQeCgEJeJQgoBN1QgAPl8oA179H6z5iI78OMJcyA/k0uTzLWKw48DePPVgJ3DZfioBokyEm2Q7YcStA033QL9m+NmnQcgJqswRoKS8GLMTGzgl00B44ZlKBlZJ+sdYjJOpjv9N8ZXC+XKLVQVRKhKamvWLFu2eS/30oh4M2yi38A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CKSJ1avyjJlcyithas5JxiodILgZvZmsTmxCDz5sA5yqPRtvMaxESn5dXJqV4XpwJxHFvGWbt0eTvZ+GCzRGFfAhGFv8oclZEUpDWoONESlNVBpyaW+X05K6V5NFYjONcMfio4WInFeKgDscHq9EY5tP7BDnN0VKfMD5hSXHjX1DmYGUN2tgj3vzgrC1Nig1ipov26Mgz0iW9B4ho1b51xJQJnCeM5qoz9PB5jcsLYbDC7tp6Dv+FBz8/N7tgR4Zu3PQBFTIGcz6WVyiYhZuB/7EcWlL8oTb1Fi/fQaJ757LJqpfBjU0kEIJmORajCbi2U++0sHCVY9LVm2+KAKriw==
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 11 Feb 2026 19:48:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
On Mon, Feb 09, 2026 at 05:40:33PM +0100, Jan Beulich wrote:
> On 05.02.2026 02:36, dmukhin@xxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Both conring{,_size} should be RO after initialization is completed.
> >
> > Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
>
> Ah yes, that's one of those things mentioned for patch 1.
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> preferably with ...
>
> > --- a/xen/drivers/char/console.c
> > +++ b/xen/drivers/char/console.c
> > @@ -346,8 +346,8 @@ size_param("conring_size", opt_conring_size);
> > #define _CONRING_SIZE (1U << CONFIG_CONRING_SHIFT)
> > #define CONRING_IDX_MASK(i) ((i) & (conring_size - 1))
> > static char __initdata _conring[_CONRING_SIZE];
> > -static char *__read_mostly conring = _conring;
> > -static uint32_t __read_mostly conring_size = _CONRING_SIZE;
> > +static char *__ro_after_init conring = _conring;
> > +static uint32_t __ro_after_init conring_size = _CONRING_SIZE;
>
> ... the type here also changed to unsigned int (as set forth by
> ./CODING_STYLE).
> Happy to adjust while committing.
Will appreciate help here.
Thanks!
>
> Jan
|
