Re: [PATCH v2 0/5] darwin: expand cross-builds to also support x86 and testing

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/02/2026 2:46 pm, Roger Pau Monne wrote:
> Hello,
>
> This series expands the recently introduced Darwin hypervisor build
> support to also allow cross-building an x86 hypervisor, that's done in
> patches 1 to 3.  Patches 4 and 5 introduce some Cirrus-CI testing to do
> cross-builds from macOS, plus it also introduces some basic smoke
> testing of the x86 builds using the XTF selftest, just like it's
> currently done for the FreeBSD builds.
>
> A result of the updated Cirrus-CI pipeline can be seen at:
>
> https://cirrus-ci.com/build/6723050642604032
>
> Thanks, Roger.
>
> Roger Pau Monne (5):
>   xen/x86: always consider '/' as a division in assembly
>   xen/tools: remove usages of `stat -c` in check-endbr.sh
>   xen/tools: fix grep reporting 'illegal byte sequence' in
>     check-endbr.sh
>   cirrus-ci: add x86 and arm64 macOS hypervisor builds
>   cirrus-ci: add x86 XTF self-tests for macOS build

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

The CI tests passing makes this a fairly obvious one to take.

But, some further observations from
https://cirrus-ci.com/task/4903778798796800

[10:09:34.952]   INIT_O  arch/x86/acpi/boot.init.o
[10:09:34.971]   LD      arch/x86/acpi/built_in.o
[10:09:34.975] x86_64-elf-ld: warning: arch/x86/acpi/boot.init.o: missing 
.note.GNU-stack section implies executable stack
[10:09:34.975] x86_64-elf-ld: NOTE: This behaviour is deprecated and will be 
removed in a future version of the linker
...
[10:09:35.720]   LD      arch/x86/boot/built_in.o
[10:09:35.724]   CC      common/hypfs.o
[10:09:35.727] x86_64-elf-ld: warning: arch/x86/boot/reloc-trampoline.o: 
missing .note.GNU-stack section implies executable stack
[10:09:35.727] x86_64-elf-ld: NOTE: This behaviour is deprecated and will be 
removed in a future version of the linker
...
[10:09:40.836]   LD      arch/x86/hvm/svm/built_in.o
[10:09:40.840] x86_64-elf-ld: warning: arch/x86/hvm/svm/vmcb.o: missing 
.note.GNU-stack section implies executable stack
[10:09:40.840] x86_64-elf-ld: NOTE: This behaviour is deprecated and will be 
removed in a future version of the linker


and various other examples too.  The warning comes when linking
built_in.o's, and while I could believe there's something weird about
*.init.o and/or reloc-trampoline.o, the complaint about vmcb.o is weird
because that's just a plain C file.

The other impacted (non built_in.o) objects look to be:

arch/x86/hvm/vmx/vvmx.o
arch/x86/pv/dom0_build.init.o
arch/x86/x86_64/cpufreq.o
common/unzstd.init.o

and it's not obvious what these have in common to be the (only) objects
lacking .note.GNU-stack.


Also, during the final link steps for xen.efi, we twice get:

[10:09:57.995] Warning: relocation to r/o section .text:00000048
[10:09:57.995] Warning: relocation to r/o section .text:00000090

which smells like the multiboot header.

~Andrew