[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86: Force HAP to be enabled when PV and shadow paging are compiled out
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Fri, 13 Feb 2026 20:13:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=goz/jyUm7qEYbHQoZvMVZ7ZvhG7iqD975RxDl3tylhY=; b=jWMtO83aE2Nn68aZy8gQepYf9RhOtUcuZXLNE7wvhU+hle4dSjlYg2b7OiMdcbAS/aFe5B0EWPl3ZZasR12kkALBXSj70FWWW3uG4XtqExFYiyTAmPKV7HLHjY1uqG7Zm59LnScmi/UAr1MnLrkW9hWyzJBHTa/sY6X6rGv3jyFGsn31KAuKMeFwKvJ02Woh+M1Lq10Ix83gmEJLa15q5MjtT/vnto5xlJEGNyHkmTTYGlk86cjYgZP+GJheks3sscWbUPr0FdTTfhwHiohJpSq+Ol/Pqf6SrIEvQNo2ey5Ci+UA/NcG1KyWNXKQ7/iKR2JPy4OszLpdeBwEthYtSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oiJP3Ch7PhRNY/9sbE8cV9PqcFMtg8iii2HxR7ivYD8QSGqYRmwkzywGalphrjCS3anCK8W5Q7XqrCtxiCFj8PcqyJNfOAB43JZ6Fa3QHdAGi2dIotBPlUU6EBPVg9pJAB9H7SRcr7KvQdDennhRpTPyjh/1SHmYFW9wpQjHBGo44DcSBDXDGmtWiaeW5LGg/FspcwLjpoq1fUdGJst7rtXz6xTvvCkO2A050fwzlbCZ2E+XUnmwZQfqM9eY2q7cY3gpaN8s1fq2tXH9RpQTvknQgFCUzA1/oozkNoqTJlRs+AqrFWOE1koOWzNfxRaXMd7xkJRyTa+cEQr/zC5pQQ==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 13 Feb 2026 19:13:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri Feb 13, 2026 at 7:42 PM CET, Roger Pau Monné wrote:
>> >> diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile
>> >> index 960f6e8409..64fde82c50 100644
>> >> --- a/xen/arch/x86/mm/Makefile
>> >> +++ b/xen/arch/x86/mm/Makefile
>> >> @@ -1,4 +1,4 @@
>> >> -obj-y += shadow/
>> >> +obj-$(CONFIG_OPT_HAP) += shadow/
>> >
>> > I think you can use:
>> >
>> > obj-$(findstring y,$(CONFIG_PV) $(CONFIG_SHADOW_PAGING)) += ...
>>
>> Hmmm. I guess I shouldn't just include it twice, like we do for other .o
>> files.
>
> I see, so use:
>
> obj-$(CONFIG_PV) += shadow/
> obj-$(CONFIG_SHADOW_PAGING) += shadow/
>
> Maybe that's simpler really, and it's a pattern we already use
> elsewhere.
I meant them being folder with makefiles potentially doing things that should
only be done once. I don't know if we dedup tokens somewhere. These makefiles
are rather arcane.
>
> Thanks, Roger.
|
