[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] x86/svm: Add Enumerations for the SVM virtual NMI
- To: Abdelkareem Abdelsaamad <abdelkareem.abdelsaamad@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 13 Feb 2026 23:08:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hWE1K8RYaS8edjK+lxXn1O3S8TYeBEC9+BCY6ocqsU=; b=RAlzsyn8Dz7R8dIb80MQkmRCu64Uj5Cfm/KIYyvfBF+Z6RVywvu+gAjWUu9t0uc6v3Ta23X9iin+Y52/QYkSpvH/GFqcrHWqyojFDpSdW+GZ4+TkWAd6UuEZclHBYJiNM9YLbCbDjtiTmxsrv8exUJCr4sl3PUTLHIK74B0GH+kpkPfpmCKu4YAz5/o5jcxZsDX4HbUqmfP22Yo9Gop/fqPwVMTRr9rt2vc9rvVYN04I8ojrTxpA/qJHGyS9BjuZ2kBMOzXAUTWsiMw1m+xK/c9FzGr8nkQA3pJpZ6rQbRtBXq3rGFAqDRMCC+6znlHw8yxIt+xOycq2MIuIVonzmw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LnBWtelWEmnkRZh+4rpTgVTjBj8iiqZ9WnqreC5A80EtTG3RqSWUK+EiSqpYyW0qgiJ24/xQv446KQFE54ulKh26My5HGTuHrL4WWGU0A7gwxboheFhYzHCNWdJGudoWVYi1oKvEykJZNSOejsfAUdsFtgvYIEtM6UQoh5KJYcb1w1hLOuBUVHikV/fH4TkFEahfngflR4WTukTGAbUHoq6dsrXnUvsme8x2W4Zy2tdF7++yVUSfeAXftrtv18JgvHO/lfXsJ1lZfFznz8QHhBoPpJdvke9xoK5+QaYIrpUasSh/NPwB5Uo4EZU91NRmyaSeaFKSW2IKEQtbseP64A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, roger.pau@xxxxxxxxxx
- Delivery-date: Fri, 13 Feb 2026 23:08:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/02/2026 10:44 pm, Abdelkareem Abdelsaamad wrote:
> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h
> b/xen/arch/x86/include/asm/hvm/hvm.h
> index 7d9774df59..ad17ea73e9 100644
> --- a/xen/arch/x86/include/asm/hvm/hvm.h
> +++ b/xen/arch/x86/include/asm/hvm/hvm.h
> @@ -115,7 +115,9 @@ struct hvm_function_table {
> virtual_intr_delivery:1,
>
> /* Nested virt capabilities */
> - nested_virt:1;
> + nested_virt:1,
> + /* virtual NMI support */
> + vNMI:1;
> } caps;
As said previously, vNMI is local to SVM, and needs to not touch common
HVM logic.
Specifically, delete this vNMI boolean and all 3 hooks you add in the
next patch (i.e. all changes to hvm.h). They're all layering violations.
~Andrew
|
