[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: device.c is init-only when OVERLAY_DTB=n
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 26 Feb 2026 17:14:28 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PAm/JWVfE9j2pDcPeeWeT9ZTp2Nhqw8kMmRdLCNcRrI=; b=cJE7dXgjBOR8ISV10r4+JSIBfxBE6qVkGnFme0Eeu2z4vRromESGb0SjRGR88RHmK6ALGB9A5wEt8mSlcT8M1p1SaQN4L0V2mG0r5npypvSHYWujvgngd1Oz4M09Ep50lzeRGKtoBvSaGuXx9/XKAtSzPoJWMRUnbkfftR4X0t0QvAlsQ4QabtTUBX/pvxSzM9pgwNzeu61n3PnZ1afTjZSMvL44vWGhSTBEoujYhzvhlIQoQcbw8u5BSBDJzxx2n6lJgXeFBUrxW0a1UUVy8FFDflQJQV5Za+PeKeQWVITm++xSDLDy20XiYuV62ma7VXj/2Y5BwHoFrOKOJYU63w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CGa4rKmyqgP8tAYIfKA7WqdvcD7zjsx5TLM/9pVgTsM4/khoyPNJzgXOsV6CUuvZ2V8OqYgN41RFMoG01qJLOltkPOP856xASyxVfslyZt0Krmt+g22a5ggKivklFWU9Xl4fIHclLDUo6Ls65PMZTQSGatGPp5AG/eF1tJIBx07A8BWhOyB3TyPzTa1rwHigX16fCgnCnRoe4guIu0iWn2XK+oY0vo27x9iGsuk9CtIpbDLCyrgC0AHTkMWIYrjjo96KNSKlZx2frWFB124E57KMzE9+0/a8tXUh+fdEHGjMoHwo94T3NjtxhFAm3GSLm/veiMuhQnnWbZcRF/ky0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Thu, 26 Feb 2026 17:14:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/02/2026 4:28 pm, Jan Beulich wrote:
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -15,7 +15,9 @@ obj-$(CONFIG_HAS_ALTERNATIVE) += alterna
> obj-y += cpuerrata.o
> obj-y += cpufeature.o
> obj-y += decode.o
> -obj-y += device.o
> +device-y := device.init.o
> +device-$(CONFIG_OVERLAY_DTB) := device.o
> +obj-y += $(device-y)
I know we've argued over this before and not come to a conclusion, but I
still firmly believe this to be an anti-pattern we should expunge.
obj-y += $(if $(CONFIG_OVERLAY_DTB),device.o,device.init.o)
conveys the meaning more clearly and succinctly.
~Andrew
|
