[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v17 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Tue, 24 Mar 2026 16:59:49 +0200
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YSuTnvHSeVcFUB/+9C4fCV2nR4/iqnZ0NXe5dDdHJdw=; fh=ER/BYFrrpCrSSVfzOMF7Ku3o0WALv6zM9JFyjgxE93g=; b=JrcCZQKw9tidmLfPJQfE126q97gI3FAOjSgklrUX27o7BEf1VL5d7LbTRL/GomJ4ix seB9I2iw8MqSC6sqlw/YOmdD0+EYTQdVzPxIeRAoWSxtEINl05ZHoRF7yxGoPc2RlshO 0t+S8IGSzSabiCSURMWKsw/LxLsDWY0W0zd7To4Qd+L1p0uXPptKsIoBLbYZDVKsoe6w I+ycHYdltRGxdanSR1Vycf6oX9mMHtrM9kU+6kFCvNiKVej9UqgAEDWTK2KoOXTheyKc clvfBqnTmkesvp2hURgXzdS4rrrgC1+drbj0pU2k+jYV0MV8YoXwjJTyNuxtLMFuy66Z +ObQ==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1774364403; cv=none; d=google.com; s=arc-20240605; b=ebVUX4F9WIWRYfrjZmvQzt6P7I+DZ8pF2Y2/b+oQWuby1blWt+5zYjIeB54Tm6Gn3W Geh/cSP//rNRlrk4lMhex4EnCZ1FxkLfSQiVPw+AcJ3aarP5c3n3E1oQXPybTRvJV8Mf tIL8ti0PkD5/MmeNxQkxmYD3h1e7IFADuLSsnX+3PUppVp+mPd4IAKI1z6GA7GwQfxhq vD/jksix8nt2d3TTwAbVwqNG4pdVpxG5wguLBieffsqtoR5JvH2YBIHd6EEE1kq/LW2+ BYpS0ZXTrELZh0haJzkVReckf1mr/gOqiGmJF4lIMHRSQycSliO6iYFQFSMY6gLARJaB pqwg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Mar 2026 15:00:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 24, 2026 at 2:53 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 24.03.2026 13:26, Mykola Kvach wrote:
> > --- /dev/null
> > +++ b/xen/include/xen/suspend.h
> > @@ -0,0 +1,25 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +
> > +#ifndef XEN_SUSPEND_H
> > +#define XEN_SUSPEND_H
> > +
> > +#if __has_include(<asm/suspend.h>)
> > +#include <asm/suspend.h>
> > +#else
> > +static inline void arch_domain_resume(struct domain *d)
> > +{
> > + (void)d;
>
> What use is this? None of our stubs does anything like that without a clear
> need.
The (void)d was only meant to make it explicit that the parameter is
intentionally unused in this no-op stub.
I find this useful as a reminder both for possible compiler
unused-parameter checks and from a MISRA-style point of view, although it
has no functional effect. Given how late this is in the series, I would
prefer to avoid another reroll for this detail alone.
Happy to send v18 if you think this is a blocker, but I'm also fine if you
want to strip that line on commit to save us both some time.
Best regards,
Mykola
>
> Jan
|
