[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/sched: validate RTDS putinfo period and budget
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- Date: Wed, 25 Mar 2026 09:43:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2RzNEiGKAjfQItZJJS0IgLaCJFzP3I0sfxeBqJoMco=; b=xELKRIpOElDT7hsI3BQEiIZXaiH0ik6vRCwTOu2HHA9WQkIkVgvbl3r8geeQ5W28FDI9rSHbSHMQHDAm7+ccCjdyGOO0hjIChlCyzGTOYEQ4VjFPaMKKpUGBbru65KA0w7KLDPvKMhGOkHQoYiZvf0/d1/XCp5N9GbBrZPYv4x1gIJVtk0ba462m5WgoDuWCyAjv1MwwrVwVdX7/4q14qdTPWTJQ2X3XC+W6evfgHH9BlL6MXiBrIWPjYn86r2CiH7/v3b0Jl1GzjoXc0CaaZrrDOiWFj1V0OBz91PHYk8cxKwRXDC3qea+y5PcNxwKayq8eehEw7zQ1ZzFshCoo7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NCQedOq13nrgNjKlKYiOtD5VhSbv8UM1kUkAXwcjno6KMdsTxmO4I71uM/0x5BoFnX2BbXpcpXjwqEh4HJyVzQL9mc6lLP3yzpuIyKy7SHPRFvcdwB7kyHUjVbQ4Y7Bv64FDHjDqG8KjHURZoAlmDB1VoUKHczUSqBL4sVKKuCo7qTN/lzvgtbeoZhLXF0h6U/wu6Y824vMNwSz0cA/dIb9sra7izHfDdDDjTdF2rzQK+9Sm2IargMkejRSoKDPJsteie7ZmnLlpmiDoYZmcCzAGP6NPbn3jPmsBz3gs0HwhCoWdR6rNZeSy2UKlnRhTADMpHI/xvZiqx0k7Efi6pw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Dario Faggioli <dfaggioli@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- Delivery-date: Wed, 25 Mar 2026 09:43:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcvDvK8gNVwMujB0ygdi3PmK3CFw==
- Thread-topic: [PATCH] xen/sched: validate RTDS putinfo period and budget
The RTDS domain-wide XEN_DOMCTL_SCHEDOP_putinfo path only checks for
zero values before applying period and budget to all vCPUs in the
domain.
This is weaker than the per-vCPU XEN_DOMCTL_SCHEDOP_putvcpuinfo path,
which already rejects values below the minimum, above the maximum, and
cases where budget exceeds period.
Use the same validation rules for putinfo as for putvcpuinfo, so
invalid domain-wide updates are rejected with -EINVAL instead of being
applied inconsistently.
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
---
xen/common/sched/rt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index 7b1f64a779..62188f37c6 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -1388,7 +1388,10 @@ rt_dom_cntl(
op->u.rtds.budget = RTDS_DEFAULT_BUDGET / MICROSECS(1);
break;
case XEN_DOMCTL_SCHEDOP_putinfo:
- if ( op->u.rtds.period == 0 || op->u.rtds.budget == 0 )
+ if ( op->u.rtds.period > RTDS_MAX_PERIOD ||
+ op->u.rtds.budget < RTDS_MIN_BUDGET ||
+ op->u.rtds.budget > op->u.rtds.period ||
+ op->u.rtds.period < RTDS_MIN_PERIOD )
{
rc = -EINVAL;
break;
--
2.43.0
base-commit: a7bf8ff218ca05eb3674fdfd2817f6cff471e96a
branch: amoi_rtds_SCHEDOP_putinfo
|
