[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] x86: Remove fpu_initialised/fpu_dirty
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Wed, 25 Mar 2026 10:43:11 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TrJgTBO+HgAU7k/miMlhva3uK06pR6mN0D9/No30HM0=; b=uOvs87Z1f5IP39MBnsEVrnnxmHUPG9O6tjK0i0kAicO6TBnRyuRd5cjQL6EkF5lFc9RpALWAej/T2WFRulNFG3xysnYZqtG/CYTFUnyAIjlIXzOlb/2ydRut5opGjypJdx1oGO0312DAzWPDDz/Vpma6Uocb5zBho70bAqkLXdfEk/WcAFwqaW4ZQ5ePdQctUPI/AeZEc++u4BEm8k/rHAdKtBp60Im78J1QG2XbUTXPes5x8gAlUXn/NW11Oq8o2gFfbehRs9n87pMDUghdwuLcjcyZnqPVnHjFMcnVQ9+AijKEXo1widd9LYm/2q0qIzDLO1+iqlfqsi9y/TH10g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qWJP3kXCj3P7TPvytByX8eJWCnhfBndLgLCofuCSi9tWPzpn7arnVb4orIffkb8+4gE+ixqHZAPTXiahlpoK8YOrDqY3YkjNmhBs3AAREGZ4w6Y41AieDI4O/ei9HVo2lpEweeR4ZZRmA5Ab2tV2EKOTA59UyarlAtsmb5nncJthXRC3Du7zONmuEU71jYxtc31UlQAj10sn+keG6AUav+ImvtfuB7sT6PyWzhywQhIdNorDI6L8gqWcDxLOF5e8P1LwezoXtCEXVwGo/45MYJJe7idI51/q2UlDZw1nF4lOs0JLHCi2rWmx230oTFyOntFW2PYfxMFca1CziA51vg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 25 Mar 2026 10:44:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/25/26 9:30 AM, Jan Beulich wrote:
On 24.03.2026 19:19, Ross Lagerwall wrote:
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1409,8 +1409,7 @@ void arch_get_info_guest(struct vcpu *v,
vcpu_guest_context_u c)
c(flags = v->arch.pv.vgc_flags & ~(VGCF_i387_valid|VGCF_in_kernel));
It ends up a little odd to clear VGCF_i387_valid here, just to ...
else
c(flags = 0);
- if ( v->fpu_initialised )
- c(flags |= VGCF_i387_valid);
+ c(flags |= VGCF_i387_valid);
... unconditionally set it afterwards. Could I talk you into cleaning
this up right away?
Sure, I can do that in the next version.
Ross
|
