[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] arinc653: overwrite entire .dom_handle[] for Dom0 slots
- To: Jürgen Groß <jgross@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 25 Mar 2026 17:37:49 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=beu4NdR+dK3AFprj+R0bdkyG6IY9mV5sGu5B3BAz++U=; b=iMliYLe8fOWQRV5SwIVdJJm3g/3D0uwbA3SyH3rv1D8HtTsycHX596wpY/9XEYX5AAU3Wyb5SaJFWC6hS5GSEcyVxaPojDhejR8FW5JPIYXsbVfuglf1BnMl3xl3Hq51EgFmEVSSGPYiVxcC57BcgXDL3jsQx7QUSHRRHd9pu4nqRCOtfBX43CpgP7IhZOcbXhvnhm1a5KMfarQ0DberCNALFlI51IvN+jgE7brfS0jxwAQTxoa+gUkcutnhBr89IrnwXzdFHjJWaNVOjQOWLvN12WDH9paGpWJpU9oeeAS2BN+ZZAXYIF/ktiaPntT+zVOk7BoeEOmgVvwxYAwmaQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dQQey1C2QfwOlVAN5jS+yTvnqMiA3iIl9vxSBpQFjRrJsWKIrSXu6SFDk7HoWQS7E1/yGrkxPyiXhBXSb1dXMzziLGd7C5xiBv9Q4pq6s3rJQUYpq9VfXxh+hB1uYmqFQkG7QEFDF1Y82FtSpe6+yxiDUmxResNPss1WzkOosb4oGe2x9v+A0f76KNKnNvPC0NihVfwcDAKJbicrIKBB2JojaFK8weN011Rrq6UnQk7MdANjQd5GCoMhuiIWnPVQNx3br35gbHWetbkpv5STHK9ZqQzRWagOU6rdUWXfQ0P3TqutDeWKz+gdCh65CpYPBM4tQbnR1+tkYKEWA38/Mg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Nathan Studer <nathan.studer@xxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart@xxxxxxx>
- Delivery-date: Wed, 25 Mar 2026 21:38:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/25/26 09:51, Jürgen Groß wrote:
> On 25.03.26 13:53, Jan Beulich wrote:
>> When that code still lived in a653sched_init(), it was redundant with the
>> earlier memset() / xzalloc(). Once moved, the full structure field needs
>> setting, as dom_handle_cmp() uses memcmp().
Nit: perhaps also mention that the concern is the dom_handle being clobbered by
arinc653_sched_set()
>> Rather than implying the
>> handle to be all zero, copy the handle out of the domain structure.
>>
>> Fixes: 9f0c658baedc ("arinc: add cpu-pool support to scheduler")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
With or without the adjustment to the commit message:
Reviewed-by: Stewart Hildebrand <stewart@xxxxxxx>
Thanks!
|
