[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] libacpi: Pass missing --dm_version to mk_dsdt


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
  • Date: Thu, 26 Mar 2026 10:40:12 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+RCVkYHkOSgKiFDNbPFC2F9keZnpzFORnrBOnLlYrhI=; b=iLV9HEzJcf8ktUwZmdMrSqn7p+iPAUMZAPEEuZ+/v5Lr+/JuT7+9UZcqkbTNXprylITduuzz4C3dADqBPwOIKWwAMdssRjB16AcZ5mI55TRhyl2NBre95ujlbPFHk/bJaEWJiJu7AkLLVV2F6tkEAajJSqPeaOq/ehBIjJM7yo8hpjR2RaWBbRaFh+nN8MWWlSRjwZrD8Fug/LxJMzQT0C6c5xykJ6RNnXynre+qKi4ElCW1spf2iiaVTwH7rb8oihlCgEh7W/6v0cGQRR/6SboC8MWWiHKInbVaI2/S+NHdCLzd5AN16bR+SCO3SjtydKzyI75h0eV98RNT0vBtOQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FMRC+Vf/SlWGhk12S4+K3IE09EPu6MrqBkVzqWcOEy1BEW38t40kLembagumzO+rRYs2E6EbZc+uPiZf/glx2pRMqKDIrxelpK2sKJMYrjmoF5p40q1jprVOZmj417bWCkBNSHPAO+auhnUYXzHp4a+ens6wZzJNQc0PeCXeWEuEfzobo69s4LfVO6qz0gdAeX33SMFKotTsTVOYX6nl6D5JNeHyybp6pb97pZfvqKoAHe+pnoh/VpzQaaFjkBa5iydd321h4Qsdhv8YRLYchFM58+RzZR4OizGi11N11nxmx6ZCU7nNrbUfyMtum4gl40jbqqLh+p0Tnav7Y2VSKg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Thu, 26 Mar 2026 10:40:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Commit 19ab8356abe4 ("tools: remove support for running a guest with
qemu-traditional") made passing --dm_version to mk_dsdt mandatory on
x86 but didn't fix all the invocations of it.

The previous default was qemu-xen-traditional so with that removed set
the dm_version to qemu-xen for this invocation.

Without this change, Xen fails to build on x86 when using
--enable-rombios.

Fixes: 19ab8356abe4 ("tools: remove support for running a guest with 
qemu-traditional")
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
---
 tools/libacpi/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
index b21a64c6b441..193ec786723f 100644
--- a/tools/libacpi/Makefile
+++ b/tools/libacpi/Makefile
@@ -51,7 +51,7 @@ $(ACPI_BUILD_DIR)/dsdt_%cpu.asl: dsdt.asl dsdt_acpi_info.asl  
$(MK_DSDT)
        # Remove last bracket
        awk 'NR > 1 {print s} {s=$$0}' $< > $@.$(TMP_SUFFIX)
        cat dsdt_acpi_info.asl >> $@.$(TMP_SUFFIX)
-       $(MK_DSDT) --debug=$(debug) --maxcpu $*  >> $@.$(TMP_SUFFIX)
+       $(MK_DSDT) --debug=$(debug) --maxcpu $* --dm-version qemu-xen >> 
$@.$(TMP_SUFFIX)
        mv -f $@.$(TMP_SUFFIX) $@
 
 $(ACPI_BUILD_DIR)/dsdt_pvh.asl: dsdt_acpi_info.asl $(MK_DSDT)
-- 
2.53.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.