Re: [PATCH v1 4/4] xen/riscv: init_csr_masks()-related improvements

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 3/24/26 3:36 PM, Jan Beulich wrote:
> On 13.03.2026 17:44, Oleksii Kurochko wrote:
> > There is no reason to use _UL() in define-s sitting in C file hence use UL
> > prefix instead.
> >
> > Drop 3d argument of INIT_CSR_MASK() and INIT_RO_ONE_MASK() to reduce risk
> > of incomplete editing after copy-and-paste, or other typo-ing.
> Another brief sentence about the AVAIL -> VALID transformation? Then ...
Sure, I will add then:
 Use _VALID_ infix instead of _AVAIL_ as the mask identifies 
architecturally defined bits, not bits available for software use.
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.

~ Oleksii