[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/time: adjust handling of negative delta in stime2tsc()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 27 Mar 2026 21:05:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cLqNwHq9MYNAGDx+8vF5IRUVzTyHXsl5Qtc8I/H4QX8=; b=Y9CoJkorjtz/nq/Nk9Ue3geR+lQ6KJlQETWZOMVMadC+16xup8CmqkH/R6H626HzJoDKWEjrAQJrgE/k7FVuRJFCNIUQus2VsTkwZofNx58QZIzsswIFXkmGchEZ4yZGRydRLT6dScJuTfnAz+0aLgdX9J7xTucwKFvKKuYEIZ1PKcZgoYXwAiKzQdIxq8eKmomjjIlKahWFh0ute18zVRrGFH71SW6epFYrQ5/qkjMgr+H4eosv6GqHIObC36hnCRkf5t3dJ0rvSXQn3efZTIRdhV/fyLdq23JSpi95DBFNeTxOurM25or8J0j7s9r3hFGUgP8/ckmAr7p10mktMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BoF0AtWX35yTwWEyQ03ZCAjQYvlz7QSVD8SW0REv58P0RcOks0LyZ4JsBbQVFKHbiDSCRm59qIFMtuNHeNUGL0c9L113JtVBXMm/jI47rNmUrrhDt+BmMizZPHJkjbP5VPUtrPoZG9VZGRE11C2V7ModgAySv+sC1RAC4+2KVoauiFbPYGDRCvGXZcuhjX6/js3pV9+4chu93ktFw/3vy9PGc8DEMBhHdmKu8IsFZVXXjKyjzTy5Oo+PnVVXhppF5wLv34FP30VYi68o14yfp/EmUOZr8aYG5K4e+WkSyk3kb8R8SaGoekw7Wgln2xKS3D0AiYPGSJ+oFDILm/i8MQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 27 Mar 2026 20:05:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 27, 2026 at 03:39:42PM +0100, Jan Beulich wrote:
> When we cap negative values to 0 (see code comment as to why), going
> through scale_delta() is pointless - it'll return 0 anyway. Therefore make
> the call conditional (and then also the one to scale_reciprocal()), adding
> a comment as to why there is this capping.
>
> Modernize types used while there, and switch to usiong initializers for
> the local variables.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|