[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] unlzma: avoid UB shift
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 30 Mar 2026 12:30:13 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YKaciZHHuvlMpBgEFguwrZbjb6za9/FhxbeiKIO+mSs=; b=q+AJwRC/KSiyp4ZeNSFsXa07rZgD5stCO956kCEN7EhifyNT4vEIGK/3opKs+wZYijO9bysGwW2aIXf8s0M/rqML+Hqkw+U1vC9BewsMEcNCqFq7zaV6MaMfjg1grkY/yCVs38YaWblkUIMNjWhazkYEhPrbPa/+OZTEBohcAyyC6zc9gVM2+JjksYwVT0v/iooP35HntdaHvTume+wSl6BYqnJ3l4+SYe8niwBthP/4LlhRkv3C8oKpP+hjT8l8M2WFByNz8zA2Q7zGWIeUqYJ8Mjq6HbU8RDMmWkZPJD4GycU7orKz/UGdvKKyBIhfAxjtsxUjBJkXG6w44lMFMw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GWYOXYsaP2DRjYyVtQRJ9Z9+3lkdgnd74+LcGCGnwJ+dk7mgGGdTJpbKRwxJpmCsb/NVSVvqI6//F3BZ/mO3kNQpQ9cCee+Wtx6fGUJnSRPgAZrX9gCMaMJlArpC/YbW5Eq+S7WEOhrBZs8ZR6G0+INSGZkd/u9bo7YG5h//1L7b1xZrtHcaq1ZC4bvfd7ihXuupisQnvRs0rfTieDP/UTOAKbzA3PQDw77nGlhILOitNeFkU7qPq/JA6rQAVtBNwI9WUh2RjZsgxxCxlmiqPGOorA0v+XFmTOOU6AaLzLaXmJkdNZySrQsrbVV+Vsgwmw3pFYrGIg2NxV8NIsf9RA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Kamil Frankowicz <kamil.frankowicz@xxxxxxx>
- Delivery-date: Mon, 30 Mar 2026 11:30:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/03/2026 3:26 pm, Jan Beulich wrote:
> Shifting signed quantities has restrictions. Since the wrapping macro of
> read_int() type-casts the result anyway, switch function return type as
> well as the local variable to the corresponding unsigned type.
>
> Reported-by: Kamil Frankowicz <kamil.frankowicz@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|