Re: [PATCH 1/2] make ioremap_attr() common

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 2/19/26 4:51 PM, Jan Beulich wrote:
> This core backing function is uniform; what varies across architectures
> are the attributes passed and hence the wrappers around it. Yet of course
> extra checking or special handling may be needed per arch, so introduce a
> suitable hook. Permit such a hook to return both adjusted and un-adjusted
> (for the page offset) pointers.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Declarations (or inline counterparts) aren't being moved around, to avoid
> the need to touch source files using the functions. Quite possibly they
> want to consistently go into xen/io.h and asm/io.h.
>
> Of course ioremap.c could also go into lib/.
>
> For RISC-V the wrappers likely should become inline functions?
These wrappers are implemented not as static inline function or macros 
as it will require to include asm/page.h into asm/io.h what will lead to 
compilation issue.
I am okay to leave them in the way they are implemented now.

For other part of the changes, everything looks okay to me:
 Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks.

~ Oleksii