[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/5] README: update minimum make to 4.1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Edwin Torok <edwin.torok@xxxxxxxxxx>
- Date: Tue, 31 Mar 2026 08:15:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zShijB4+cGR43ywKEGBDdaXIcwhh/XzOdA/FzmKxuzg=; b=s21YhghIVPl0qQYCLghw1vttyWUkaf/+yOl2C+homelz44hDIDC2+MJedwI+c07vcNbIERNyCHZ3JbHBtBB/BUzguE8f7RcXk+eHDM46fpqMZSkucdj/p192mw2AuMa2McnvcpuxjTQFUNjScWCv2VLW+6rmZwIxZjtAp3WKM4pZDhUi2lUdsgMZ+qKKVyEwUiuvm/irAWvzpZwq+NBIKyogp97/XkgVxjuc2UrYaXtb8cnaseqFJyIwPBhExfMnYEbLoVnhYn/MYp3by1yQgv6jLyW6U0kPaoHgQX7nQW5r8hzS4K1fB/p0zAUCwaDmJIfjAD4tO1qcTJFrdOLdzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hkJL/owkMX2P7AQEAezuwTHrUhife0B0vLuN2yv5uStj3yMN1fSBWxAmG0UYkuR4rDGU0o98f25EGY557Sv4u7olSc7ItBaHjc4AKzj+TKIxVTzJ0FUg9fXUuSSGv7CMTBGWEta7XFA3AIULt3ohHC0/1UrE2UsBhfHX1mQ+VFxuPP+t6mikz1th+o6kV5hWPUKMhJIFiIQXFYfKF8hxbFg29t7yZaxzi34OJTMNfc7LFOaa+5CV+lM1jf8Y/X/bAA22AA8A7T1vaMOoLjmDkRhaQEeWD5rII8IUeKXvVA246S2/8R4iKfZDInHXxLSBnhCdBm+VQeigNGJal5/S4w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 31 Mar 2026 08:15:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcwGC/br3u5UUhvkGzDiCK7sswX7XIKoSAgAAhq4A=
- Thread-topic: [PATCH v1 1/5] README: update minimum make to 4.1
> On 31 Mar 2026, at 07:14, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 30.03.2026 18:17, Edwin Török wrote:
>> Using .DEFAULT_GOAL requires at least GNU make 3.81.
>> It was suggested to update make to match ~2015 era gcc/binutils, hence
>> 4.1.
>>
>> Signed-off-by: Edwin Török <edwin.torok@xxxxxxxxxx>
>> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Link:
>> https://lore.kernel.org/xen-devel/c0ba57bb-0d86-4209-b019-daf8328b5205@xxxxxxxx/
>
> Unless we're specifically meaning to use 4.1 features, personally I'd prefer
> the lower 4.0
OK.
> (which is what I have on my main dev workstation).
Which OS/distribution are you using?
It’d be best to add that to the CI, such that there is at least one
configuration testing the minimum versions listed in the README.
(Or at least the intersection of the versions of build tools in the CI should
match the ones in the README)
Best regards,
—Edwin
>
> Also, nit: Tags in chronological order, please.
>
> Jan
>
>> --- a/README
>> +++ b/README
>> @@ -35,7 +35,7 @@ Second, there are a number of prerequisites for building a
>> Xen source
>> release. Make sure you have all the following installed, either by
>> visiting the project webpage or installing a pre-built package
>> provided by your OS distributor:
>> - * GNU Make v3.80 or later
>> + * GNU Make v4.1 or later
>> * C compiler and linker:
>> - For x86:
>> - GCC 5.1 or later
>
|
