[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v17 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Tue, 31 Mar 2026 12:22:42 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HH8nGTmv9aJD+zEWW9cyBJtLtU+zFivyeHZiC0SYTmk=; fh=XPwOTaEPrdk2pN2RgjfihMkJ4NQu8t1nAUIywJrC5RY=; b=XHivl5oNS4EguZSIMD7yY1lsKg1ijHtluqH4ynlNvEqnKHr0mEDWXZ6CBRZy6zHMsc +kSAe0MOwKWabcxL9QEkdaLhSkP1vUDNZrznrnimeik4BlJnLFg2h2Akm/Xw7PSiHQhv xLBWsjqHhGO938LZQ7zJGXQM254JhpbXhVyKp2mNDAspN+CBf2SnqKouKYq8A4E+uUkq /4fdIIhs96i7QiBrn/cocUGJKsRIbm0PU9W6QLlPK3sXzNkPZciNVjdIcCJ8zq0Gkya0 loIrDmP6HIQjVTtSTxIGgtKjJ33ccQ0AELIzpONK4W5EAoQn6/PWM7M0yNSPCZ4RjRUF hCYw==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1774948974; cv=none; d=google.com; s=arc-20240605; b=S+KzXaWv7MpKqFUHlbDukjm3bgLrbJ2w24/ACWz5eAuuSku/3yjo+CC+aO4QkrTGZ5 +vRb9Cp8Y6GudAeQlFw7Fu3qfTYzB5dMgEv+6hPIEyQS8vou3Pgyevbfoh6v04dTW4nT /5zAvY7WGFq7IcROhqvOfNtzhIVt0Y1wO4SjfQ+hpRyWcbNlOeRIU6+WlubB6ld329dQ CFJEy7LoHI7Qt5k9yQbUfzkB36NlDOjQlPEvbCLWgkepQamdzZT3evHbL8dA/TmD0ad5 JFR9uYqKnZ4o3LmoZ1uOf5J8rrWnDgPYCc2KNMDve0zB1Lx8UYP47Hx+FrWXS15xHCvy zylQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 31 Mar 2026 09:22:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On Tue, Mar 31, 2026 at 11:52 AM Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>
>
>
> On 24/03/2026 13:26, Mykola Kvach wrote:
> > From: Mykola Kvach <mykola_kvach@xxxxxxxx>
> >
> > Add support for the PSCI SYSTEM_SUSPEND function in the vPSCI interface,
> > allowing guests to request suspend via the PSCI v1.0+ SYSTEM_SUSPEND call
> > (both 32-bit and 64-bit variants).
> >
> > Implementation details:
> > - Add SYSTEM_SUSPEND function IDs to PSCI definitions
> > - Trap and handle SYSTEM_SUSPEND in vPSCI
> > - Reject SYSTEM_SUSPEND for the hardware domain to avoid host shutdown
> > - Require all secondary VCPUs to be offline before suspend
> > - Split arch_set_info_guest() into arch_vcpu_validate_guest_context() and
> > arch_vcpu_apply_guest_context() for reuse by vPSCI
> > - Add vpsci_build_guest_context() helper and store prevalidated context in
> > resume_ctx; resume applies it and frees it
> > - Add arch_domain_resume() function is an architecture-specific hook that
> > is invoked during domain resume to perform any necessary setup or
> > restoration steps required by the platform.
> >
> > Usage:
> >
> > For Linux-based guests, suspend can be initiated with:
> > echo mem > /sys/power/state
> > or via:
> > systemctl suspend
> >
> > Resume from control domain:
> > xl resume <domain>
> >
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> I'll do the change Jan mentioned on commit.
Thanks for the review and for taking care of Jan's suggested change.
Best regards,
Mykola
>
> ~Michal
>
|
