|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 4/4] xen/riscv: init_csr_masks()-related improvements
On 4/1/26 8:19 AM, Jan Beulich wrote: On 31.03.2026 21:04, Oleksii Kurochko wrote:There is no reason to use _UL() in define-s sitting in C file hence use UL suffix instead. Drop 3d argument of INIT_CSR_MASK() and INIT_RO_ONE_MASK() to reduce risk of incomplete editing after copy-and-paste, or other typo-ing. Use _VALID_ infix instead of _AVAIL_ as the mask identifies architecturally defined bits, not bits available for software use. Suggested-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>Seeing this is ready to go in, am I overlooking any dependency on earlier patches, or could this indeed go in right away? No, there is no any dependency, it could go earlier then other patches of this patch series. Thanks. ~ Oleksii
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |