[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] xen/arm: acpi: Rename local acpi_size to avoid shadowing typedef

To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Thu, 2 Apr 2026 03:30:50 +0100
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Delivery-date: Thu, 02 Apr 2026 02:31:18 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Michal,

On 01/04/2026 15:58, Michal Orzel wrote:

Rename the local variable acpi_size to acpi_len in
estimate_acpi_efi_size() to avoid shadowing the acpi_size typedef
from xen/include/acpi/actypes.h.


We can't change actypes.h but I wish they were suffixing the types with _t.


This resolves a MISRA C Rule 5.6 violation.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>


Acked-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall

References:
- [PATCH 0/3] Misc MISRA fixes from Arm allcode report
  - From: Michal Orzel
- [PATCH 1/3] xen/arm: acpi: Rename local acpi_size to avoid shadowing typedef
  - From: Michal Orzel

Prev by Date: Re: IOMMU faults after S3
Next by Date: Re: [PATCH 2/3] xen/arm: pci: Narrow scope of file-local symbols
Previous by thread: [PATCH 1/3] xen/arm: acpi: Rename local acpi_size to avoid shadowing typedef
Next by thread: [PATCH 3/3] xen/arm: vpci: Move content of xen/arch/arm/vpci.h to arch header
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.