Re: [PATCH v1 12/27] xen/riscv: introduce aia_init() and aia_available()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.03.2026 18:08, Oleksii Kurochko wrote:
> aia_init() is going to contain all the stuff related to AIA initialization.
> At the moment, it is just Check if SSAIA extension is available and if yes
> set is_aia_available to true.

And (future) users of aia_available() can't directly call
riscv_isa_extension_available()? Nor can aia_available() be a convenience
wrapper around that call? It's only ...

> --- /dev/null
> +++ b/xen/arch/riscv/aia.c
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#include <xen/errno.h>
> +#include <xen/init.h>
> +#include <xen/sections.h>
> +#include <xen/types.h>
> +
> +#include <asm/cpufeature.h>
> +
> +static bool __ro_after_init is_aia_available;

... a boolean, yes, but still.

> +bool aia_available(void)
> +{
> +    return is_aia_available;
> +}
> +
> +int __init aia_init(void)
> +{
> +    if ( !riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ssaia) )
> +        return -ENODEV;
> +
> +    is_aia_available = true;
> +
> +    return 0;
> +}

Why the return value, when ...

> --- a/xen/arch/riscv/intc.c
> +++ b/xen/arch/riscv/intc.c
> @@ -8,6 +8,7 @@
>  #include <xen/lib.h>
>  #include <xen/spinlock.h>
>  
> +#include <asm/aia.h>
>  #include <asm/intc.h>
>  
>  static const struct intc_hw_operations *__ro_after_init intc_hw_ops;
> @@ -27,6 +28,8 @@ void __init intc_preinit(void)
>  
>  void __init intc_init(void)
>  {
> +    aia_init();

... the sole caller doesn't care?

Jan