[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/arm: vpci: Move content of xen/arch/arm/vpci.h to arch header
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 2 Apr 2026 13:52:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=guZ76xgGdbjnIGMb4dvq5+mcx2b3gMQVs8akOL7JWVs=; b=TL8uyYUEiu2GClRss+G+wbh/cRuYNY2UlcyjiJQfxPgfllU0cx0PAoM+/QcPdBt6Hzt0aMZ3IOffCEnT/v+kXWVo1iXOVW2b20qDDIRjkGyIGwkUKYvRWbVM4wvpU58zQZZvmVdV1yMKuwjbQmN6toj/OFCqbC9/1OJyagxPzo56kivwcCNZ6B+gjJSMcvBUdHsiks5hTARM3i+X5azOlK7/hzWKoVlKkAwqWNElJ6TgSlEccnER6TJfH60d2fY1ulBKx93kWwyXrq4VSNy5SVakriySm7KJZnrEi8KXnFLkUinzYTPszfg+uSD/ASiTqvA7A7EvNKQeVSz+HmCRvg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=guZ76xgGdbjnIGMb4dvq5+mcx2b3gMQVs8akOL7JWVs=; b=NtYDFBNCPUPtjJRRLNzDfteg7mfClholAQblOml4mEt7oKM9IPpEVjNwFP5sek5KJhXl4d0P4v/M9h/OAL4R9f+AVwrvLbrQiHQ86Z7cCcB0u2jcnkBU+vQmpTCqMGp5UGCunenspZlS+Ebbrk6eCf90YmASeZM+mlrZ1I/Z78XITGb5zQ02+bOzthDjF2+OqLYTsehVcbrOq9KGEw3+bxFFRw1A+bp6G6dgFA7QRQOo8MMrKraExKSW1vFZxi3GQ/t6gERX2dSZnOkNEwTASsatX+QCJUgqigv5upqEwzDFmaq04Tymq0aDH6oym1ZoUa0YTPj0Hb7uolI15X/hXg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Fznp38IiYihEhsiUIK/mTxsHj6u1fw9aBea03SEAaBGAq5KE+naLSsu1gYHu+5CAV3XQ6LaY3E8O9evc2Wbc/NCMiUZw5IZTNf8ZpsVj6lFaDJhMe9CAnhupkI6zkpREjPNkydBBWeTLitsunY0UxoY/LeoSkO0LYayGhvDS+aFLFsza8hCmATDGTtTQB2s1CttqE2/UlREiQqfUczrlX8zkuZOMrgaHwUNxCpvucJuNSyNlQIVzNFWbY3t1KENaK8L+Mf9FPhpqCXuUvmZ3fHovUWloO6dDMZZT7UvpnlLaO4RZjJHlCDjZlCjJUsywRO4sHE/ojTZVSyjh45caIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NKcJFd1hC0zayjPgfo8XuP5E6lfm/0cK8jie/B2cHsY2UN9d9gf80DJ0VGgmailooNxvNBCE2OTm5tZjg3ewiW9YYO1UplZCGHtGJBeFO8e6Am2xMUrQrgXBcPsaov67WbgXRzHXNiI4fao0MMLRC3XfhVGqPI22lMGYK0Uip3qsuwFgp9B6iBLAxwepYaLVuAnkmrc254UgggncpBcP3y+c91AqUx3q+a/20TU1gGdk7Wnrjj1v/lMJ5v/IZvo4ivVzTDFX65jh4JvNOEt5prsUXRYebyu61QdmMM1dOmNVA/wr3hC8d2RX3PS1DEHx1qSSQwVHzuVdO0DMLrIq8Q==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 02 Apr 2026 13:53:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcwqf1UiwmSRu720SQ2OCjFIvjkQ==
- Thread-topic: [PATCH 3/3] xen/arm: vpci: Move content of xen/arch/arm/vpci.h to arch header
Hi Michal,
> On 1 Apr 2026, at 15:58, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Move domain_vpci_init() and domain_vpci_get_num_mmio_handlers()
> declarations from the private xen/arch/arm/vpci.h into the public
> xen/arch/arm/include/asm/vpci.h, and remove the now redundant
> private header.
>
> Update domain.c to include <asm/vpci.h> instead of the removed private
> header.
>
> This ensures the declarations are visible where the functions are
> defined, resolving a MISRA C Rule 8.4 violation.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> I'm moving a file with GPL2+ license to a file with GPL2-only. I consider this
> ok in this case becase the copyright on a file with just prototypes does not
> make any sense and a license text was most likely blindly copy-pasted like for
> most of the files in that era.
> ---
> xen/arch/arm/domain.c | 2 +-
> xen/arch/arm/include/asm/vpci.h | 18 ++++++++++++++
> xen/arch/arm/vpci.h | 42 ---------------------------------
> 3 files changed, 19 insertions(+), 43 deletions(-)
> delete mode 100644 xen/arch/arm/vpci.h
I’m ok for the move, you need to chase EPAM approval
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
