[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] ns16550: harden name/value pair parsing
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 7 Apr 2026 11:01:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0QJ7FxsW/Npm05lZODgUo5FJUy+cB+G8ycOZ+diugj8=; b=fol+QJOzW7ZWKZZStmIj1uLAe9pcwQ/UR+lRrL26a1zGZAxTuS3DZQWL+ysPepSOD7bYnRVLno05BhvUay6Am8vtAAPqJVn9BZFn0bbEc3B0yGnfRQ+kpkSnyhqwdqTVCL1EP0uikmjbbQVBpTyS8NCYwg52ZLgPa661DbWBP/BwiYii6W2C62dvyDPCgyngsYkXirgqYEnmlQSugOHu69dIXbVwRkDDQIdDwIeOeCOwTRqMYGCCgJqNWAg+kZxwMcHN63cvGatGvosGja4w8QDlFW7Q4gaidRV0/MdsyFB3TGV7PIX6NbCLMA2GtbT7agKH36lhjVarx3rpX70E9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CPQJigelncbopTynQr0diM52lv8UfpnNEBM3RovntKSBi5isY9zosHhA5X1kOuylQoTZdVwd8wAjge5qIXNslQChOFgJtXC5esC/Q9D03pGpexIVIFPsV3dcNgHOtwLBBxDalcarsGgazqet184XD/QIyG6CBLvlNI88BE4FyShkMU4VQ7ZOXcTWXBneDDkxEo+rSSbNnnEAdS44GgEk/n2MtTYFkvDv9wzasADGignRsWMGp1rInnDU0wnRSRaw+5dyQo41Dm20PJ3S4mf+RQAHmbuWR8coXBhZuq1YjUMPr48Hb3X/Mv2x077tYuW6NJgD2rf/uo/Ae4/0If55AA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Kamil Frankowicz <kamil.frankowicz@xxxxxxx>
- Delivery-date: Tue, 07 Apr 2026 10:01:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/03/2026 4:38 pm, Jan Beulich wrote:
> strsep(), unless passed a 1st argument which itself points at a NULL
> pointer, won't return NULL. Instead if the separator(s) looked for isn't
> found, that pointed-to field would be updated to hold NULL. Hence the
> important check in get_token() is for token to be non-NULL after the call
> (which get_token()'s callers rely upon), while the checking of param_name
> is left there just in case.
>
> Fixes: 97fd49a7e074 ("ns16550: add support for UART parameters to be specifed
> with name-value pairs")
> Reported-by: Kamil Frankowicz <kamil.frankowicz@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
