[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] iommu/arm: ipmmu-vmsa: Fix variable shadowing


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Tue, 7 Apr 2026 12:34:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nSwn/eZd22mkj92Lxkd7s8YIYQ6Q3aCLzhHR4QqHess=; b=An4o+z4kI/l7sv+mBi8Xxt5xDEFMx6bmsbvMb8nIiJbLg9lzT+hzN0bIkm5tfronTJq3X2c/HV1k4lU5E311B+rk3yHag+z4SGays5s4IthmE2Zn65/NboujllGn8gscoF+/YbYAIYRHFd/3OLp8N8zCqcycEafLMQHcwXSDB7tT83ATRy2UJlI4kfkTT7zMHQE/kdGTFGxXJpoB1wOxlwVdTZdb6KTS5AYc4y8Ua0w+0O8Qy9xDr5uZzIVc5CbQhItRr8Tq52GeLZInr9f5PjzzGogKuUjLBsJFEIq5iP89kfIHG779WXKm4yoMv7k4VAOYjmY/Cr3tJsxoiCxiEA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mTHUU4hgpNv43oTMmGQpoEem9sORjHUatH9ZtawaPM0dL+c8ieetnRBQ8a+WrLZYGF8AK9yYNgFhvaPKShSnNv3apwj/PdQsV5oEr3IIXkAnqPvzSSM5o9j8DroXFqzFyrq87/3Izaei/y2edjt57qtuqL3FKMM721g3fQX/bSe/GJZyAWvj5p+4Ye9/FDON/RPe5CylUjRKeag1+3ZQVcJslj8M5aQejs1Xvez9T2TXhqbA5Y0/d502CYs21O40KBO0eejclB7f6Sz/Ei/QVM2Xmz2nn9ePLoXUdR8dxrfbIp9VHJ/9Ei9Sjmf9v5QIS2pBJ81V2q/uJ1L8sdQH/g==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 07 Apr 2026 10:34:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Rename 'pdev' to 'pci_dev' in the dev_print_pci() macro to avoid
shadowing local 'pdev' variables at call sites.

Remove the unused 'ret' declaration from ipmmu_assign_device() where
the function-scope 'ret' is sufficient.

This fixes MISRA C R5.3.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c 
b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index ea9fa9ddf3ce..fa9ab9cb1330 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -65,8 +65,8 @@
         printk(lvl "ipmmu: %s: " fmt, dev_name((dev)), ## __VA_ARGS__);  \
     else                                                                \
     {                                                                   \
-        struct pci_dev *pdev = dev_to_pci((dev));                       \
-        printk(lvl "ipmmu: %pp: " fmt, &pdev->sbdf, ## __VA_ARGS__);     \
+        struct pci_dev *pci_dev = dev_to_pci((dev));                       \
+        printk(lvl "ipmmu: %pp: " fmt, &pci_dev->sbdf, ## __VA_ARGS__);     \
     }                                                                   \
 })
 #endif
@@ -1171,8 +1171,6 @@ static int ipmmu_assign_device(struct domain *d, u8 
devfn, struct device *dev,
         /* dom_io is used as a sentinel for quarantined devices */
         if ( d == dom_io )
         {
-            int ret;
-
             /*
              * Try to de-assign: do not return error if it was already
              * de-assigned.
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.