[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] make ioremap_attr() common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 9 Apr 2026 09:52:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/cAl1/K0W7o6SLMZDfrL1uSCh+QCcLnxQSrjxPegdRY=; b=ojJG3n/i6RMNj0Yn5j4n3sAhr8J1H5az3Fe5W1noybHt0kYZaS5RhoTGSuuG1QmPz6bDAwiZsOW+jJBTTMb7iR5xhrIqMPrYtqr9FqwhH3HkjE+4+WnaoQuWKDdeYam1S91Ihu+RQMfOGjqtK41YarWc5VMjsQyFSsKcL86XA7H0zAvmmbSHR4FvVhxcGrGW3Yc4MJ2Z1sK9riF8fUd8qXUHYTBmYPlOnwAJEwigIzqdOaObUFg+WaD1ShNxkrO8e6ftViIbDY+iXAo0Nfi6y65rlCC9TwVM3cqbmFar3jkI7q+0y/d9wH5qOODM5Wa/jSOXEa6P0tW1MrW5cbQHZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M1V4Qbgqix8rfr4w6A67NI8tZHFyr9aF+1AtKqJx04jsPv6xn+6+8tH+fDkI6uooQ6H0Uz5NAvL11jrEXKweUKXgo3AH6G3GvU0SdgxNSMSK97aVDqsv4NeoK6AStORfQBhFlnEGbdXSp0TgI7tGGnpde3sz8t6DXy3u0gk/rSNSWA74FVEYw4WxDwqxe541uoll3vCbMPxRfo75jDzdhygghZL29jkc5Z4gdo/vYhjhksfcwsDKioCY7CkSHJGjBFtcC5EW1JlKiCZoeApzXia5q1GpGWMXE2q17EPH+4xVYvRQYIUcgUAZJINfzzOAo/MesI6fm9OBiGqktX2kkA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 07:52:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 08, 2026 at 02:07:23PM +0200, Jan Beulich wrote:
> This core backing function is uniform; what varies across architectures
> are the attributes passed and hence the wrappers around it. Yet of course
> extra checking or special handling may be needed per arch, so introduce a
> suitable hook.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Just looked at the common and x86 bits, both LGTM.
> ---
> Declarations (or inline counterparts) aren't being moved around, to avoid
> the need to touch source files using the functions. Quite possibly they
> want to consistently go into xen/io.h and asm/io.h.
>
> Of course ioremap.c could also go into lib/.
Maybe I'm missing the point, but what's the benefit for it to go into
lib/? Is there any realistic scenario where we might have a
functional hypervisor build that doesn't require ioremap?
Thanks, Roger.
|
