[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm: Fix off-by-one in iomem_deny_access() calls
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 9 Apr 2026 13:34:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUUirdYv3qlVQmlxhfpr4M8OF6ecU94LNQgny7wegC0=; b=j7qT0uQyv6QuOyJd74RRGL+hsamVbTnXoYnQVSyt9GdZQEK/lZAH+eitu2C3qokMDjluv9Tw1ViDWMzqr1BTbeqYBUx+qbmuoGnIu4fVMtvQyUpXQbN7xiTq5CCl7zPPK5tJ9cE/WN8G5Xq1nXUz27LmcvhZc1XUCu8EdDPmOLH892Wo8KjvTuY/Hf7lxIO8alTt6maI/+xLpRdEueJjEFr1r+bPjnOq3xxb05H6IPcR5mqhPeDej79HWZKVpeypIY1sB7Ud0VUw1E9cwtIUBm22LmASSoZDM4MDOXYvfn8hZzfbBfIATtjNKeu8K+UnOqgxQUiKMt4tJxhWWzRzrA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUUirdYv3qlVQmlxhfpr4M8OF6ecU94LNQgny7wegC0=; b=oQ8dfitK2QCplEc7kzQy7qqPUTJiYw1U4lIwWxOHtD1Pzq8TDBLNsdFUYE5KaZN950zaoCnZz+uDL2R3qjLdO2Xn9gnLHBVt4TIvyEJ8LicYzUPlbMUQjJ5UsY/F/iIs/chp6Wlwy0lZXpsUlaQTQm3YRMZYodhDol23SZRn7iJK43+SYyY9MaV+SaJ1EnRwEGoOhoH1MMntEBGP4xkQTl37F3geBVP0et7iiYIgKdkDXT6h4q7Kn9MNhh4WKTqryWwoDL1ttcglXS+PMdpS7Ca4A7IW9SEPjSAo/N5CqYVQbGmhEXm0DV6BZpp+WHXj7Ng3QF1SqiWJD0WnJDAHJA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ZN3eC187UApebdY9DknF2Ks7kCsmymWsY1XdMWO5PVTaoax0NlbLq3D1NuClVxIW6yC6o13ph5Pg/Ldz6E+5ecwCy8CfGk/vWSy5/liMxeMxVltlHIBD/HW8rrgvkC+msemrbUUsWJ9g3gGBZEE6Kv9CO0MI1Xip5EotpXJsf0gVqt0UJgP7Yjfto4LQ0rA8TG0P/LbPyB6nqEUuPRCRjz5mSNk35nytxXD11K2YhMyAr8BnubaRX0CJAuHJsm3CllhxS2jprhx/EUv/Ubq6Lqa5jHLDYFuHVyiNPeJHb1lKyYXPt2Dix9BBp6crYvnsMEwtwqxk5acq4BNMTgf2kg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XpAVx41Z46KRSNQJ3HL6Cmmd5r+1QoIIgdN1pcRqrU1tn19PfXHn25vTkjig7ZdXk2oxzoTpRxtLWhUMOKOyaGby4Li5WkDcZIoHNVbVqLP39/zpJazBHTMm1ivfZSoE9JK+mu4ATGN3ml3bcuQpyENYtwRmte/YU0QUY+iURIRU9PcQSM7m+uKUtFOswwqiR2foIzfdXJOwO3I/6d9oprtCRoH9kzoy/Dx2FO2EdoWcuFWl1FC33O6J0qEHUOr1CfMPo5SE/NzPupgA2ZwdXB/qsKRUpzwtxsBDn02HCnB3GEPSzrCyPg8y4zD3DsENTL5jgRwG43/pjT5ozMBOew==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 13:35:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcyBWemfhBb1SSBU2NDn/Cp3Sjk7XWus6A
- Thread-topic: [PATCH 1/3] xen/arm: Fix off-by-one in iomem_deny_access() calls
Hi Michal,
> On 9 Apr 2026, at 12:39, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> iomem_deny_access() wraps rangeset_remove_range() which takes inclusive
> endpoints. All call sites in the GIC and ACPI code pass 'mfn + nr' (or
> 'mfn + 1' for single-page regions) as the end parameter, which causes
> one extra page beyond each region to be denied.
>
> For single-page regions, use 'mfn' as the end (denying exactly one page).
> For all multi-page regions, use 'mfn + nr - 1'.
>
> This matches the correct pattern used elsewhere, e.g. in device.c.
>
> Fixes: 8300b3377e ("arm/gic: Add a new callback to deny Dom0 access to GIC
> regions")
> Fixes: 66158be465 ("ARM: ITS: Deny hardware domain access to ITS")
> Fixes: 97e9875646 ("arm/acpi: Permit MMIO access of Xen unused devices for
> Dom0")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
>
This looks ok to me.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
