[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] VT-d: avoid multi-message-MSI check for HPET
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 9 Apr 2026 19:36:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UHdPM72qPxAnbDAsGFPnhI/+0aVo8errphOdlGj59p4=; b=N1+Z88o44ky3x7PV2cCO2cg7tjhZFPvFYsgL/10ArByBr3tq4+FG/rEd7dmgviVexCAY0hHDT9ORMuhnwPpXAfQoiRozJAFJWLnkPzlHQaA64zWWYsaiMWsUu95sMCgY3WZCVQTA7T4HSsXH/PyuiYT9SkxVIxR9GuH9lIrtnz1qktJXGzgdfdp8YIqBKa6THe2Ep28UQTTXPQ1oRCBNNcBzo83S1pumii5r5fETm8w8AUxTctTvRzaSGRCuUjkbEm+89bAQJKeOS19fDY9bkcqsC4ph+XLoG4vHOuB968gPTr26OreN2SS6/SRbUqRRJJVgh00YgX5rnp1kOvf3sA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HZj+AhYvueHcOtoL5ybuRMxm8lGub9YzYrN+Zeb3PwsaOt+7OFnI815Zss6fmo7RdGvs69t8q//KZ4UZnOQoC0kOV/EARBqj4JHMBt471LK/IliNmkEec+j24I077h/uHJT4taVCHjRvJTaxT3NwEVbt+HfUqeXrL4goBUFlteEeLLFCkn8O1eiksI6olh//cFj4cau0uEtOhQtk/rfhLoDxHnGaT+YpqmMlnyaG5fEUDMY2W7zXy/XKMXwMp/Cw2Tq/qHT3I3nEkNJalyjAYnjuTIAlIhliKjIn3q4sUiNASJzk0OvbFXSshG4Fc/amJBDVz36QlKZJE4D2FzSwRg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 17:36:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 01, 2026 at 02:47:48PM +0200, Jan Beulich wrote:
> Having this immediately below a PCI-dev vs HPET conditional is (mildly)
> confusing. Move that if() into the body of the earlier one.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -513,13 +513,13 @@ static int msi_msg_to_remap_entry(
>
> if ( rc )
> return rc;
> +
> + if ( msi_desc->msi_attrib.type == PCI_CAP_ID_MSI )
> + nr = msi_desc->msi.nvec;
> }
> else
> set_hpet_source_id(msi_desc->hpet_id, &new_ire);
>
> - if ( msi_desc->msi_attrib.type == PCI_CAP_ID_MSI )
> - nr = msi_desc->msi.nvec;
> -
I'm not fully opposed to this, but maybe it would be good to add a
small comment to note that HPET never use multi-vector MSI?
Thanks, Roger.
|
