[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/x86: Check supported features even for PVH dom0
- To: Frediano Ziglio <freddy77@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 9 Apr 2026 20:04:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mB3dzvAGCQE967Hw/ykIYrSjyTIKAmbHqZBhScWZnXI=; b=aifrfp4c8fbpZWcyfwglKdL/EPQNmXHF7hZk1rZDKE4BnrM0BhXHGv833XFVnwks2GbmkheAaczD3xGafq3SaJEyNgDcZ9uznP29EXcvbK03uIxv14AVYcLCKY82VBRhy6rTK7H4HL6A/lViqMGzClQtZfqLJkGgxXEJvmdcR6puxNK2zCYrn559cPhCoeBrp9ZClr50QcJDAf/zRcBf3ye2dipbaxnHM23ELrHUDUQoap1y4+KNUDtsDictkL2qgL8BQjkFtJ3PVVQQK176+Agb01hCW4ObPRxbJtaP/eNxDM/kKcEXQgmIZrRmL8U/iyw2vK9ACfKWCr3rh6/A7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IS7accLxKVZjfKYICCDjVq07rkvsv7gUOt3qCyFjguQg8gY20ebgeEMMrnMccfDEMnYDGBXdcel3zFzU8gNx5hlN3AOHekr3KuhVdGyKYvYMTmU8HDrZt4bM/f81Ov2Rn4ApCpyAy3tqPwiAKagGPg7wikci3evq/dqjg1WcqQ6Is3xBSB457iXCvxvCb4q/U0BazlvdnN+nXCeTeLQV9mrE9QfPe7PZalxF7Crj6nrdiKS79nbkwDnhyDS79InWbBvN0fhJN0hrXKnumro8LpUFMQmQURvpcg7K02BpgbecfWCpFOEyJk30EMYZbQ+NKnz800kOePlS0JzgNe7yuQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Frediano Ziglio <frediano.ziglio@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 19:04:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/04/2026 1:55 pm, Frediano Ziglio wrote:
> diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
> index 864dd9e53e..56eba8f59a 100644
> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -320,6 +320,20 @@ unsigned long __init dom0_paging_pages(const struct
> domain *d,
> return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT);
> }
>
> +int __init initdom_check_parms(
> + const struct domain *d, const struct elf_dom_parms *parms)
> +{
> + if ( parms->elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type ==
> XEN_ENT_NONE )
> + return 0;
> +
> + if ( is_hardware_domain(d) && !test_bit(XENFEAT_dom0,
> parms->f_supported) )
> + {
> + printk("Kernel does not support Dom0 operation\n");
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
Your v1 structure was better (give or take whitespace mangling).
This needs to be a nested pair of if() conditions to not need rewriting
when SecureBoot check is added.
I'm going to fold this adjustment and commit it, because I need this
patch to fix a separate bug in the patchqueue.
~Andrew
|
