Re: [PATCH v1 08/27] xen/riscv: implement make_arch_nodes()

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 4/1/26 4:29 PM, Jan Beulich wrote:
> On 10.03.2026 18:08, Oleksii Kurochko wrote:
> > No RISC-V-specific nodes need to be created at the moment,
> > so make_arch_nodes() is implemented to simply return 0.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Same question as on the previous patch, albeit to a lesser degree: An
> arch hook may plausibly exist (and be called) uniformly, even if on
> some arch-es it doesn't do anything.
I'm using it to provide a node for emulated UART, something like Arm 
does for VPL011 by calling of make_vpl011_uart_node().
> > ---
> >   xen/arch/riscv/Makefile         |  1 +
> >   xen/arch/riscv/dom0less-build.c | 11 +++++++++++
> >   2 files changed, 12 insertions(+)
> >   create mode 100644 xen/arch/riscv/dom0less-build.c
> Further, on what basis is this function put in this new file, when the
> earlier ones live in domain-build.c?
Because it is called only for dom0less path, but previous one called 
from both dom0 and dom0less path.
> > --- a/xen/arch/riscv/Makefile
> > +++ b/xen/arch/riscv/Makefile
> > @@ -1,5 +1,6 @@
> >   obj-y += aplic.o
> >   obj-y += cpufeature.o
> > +obj-y += dom0less-build.o
> obj-$(CONFIG_DOM0LESS_BOOT) += dom0less-build.init.o>
> just like Arm has it?
It makes sense.

Thanks.

~ Oleksii