[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/23] xen/arm: vIOMMU: Add cmdline boot option "viommu = <string>"
- To: Milan Djokic <milan_djokic@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 10 Apr 2026 14:28:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuNN5Xsm5V2t8jdqc1464X6IJZt1tsqeNB7XDP/BdVQ=; b=Y9Q5UH5gtw1ony9jgXevIq2do9tvKdmd0K6CtU61CaBEkfPEzun0IF/HytXSmaakLNrdKMbojTbBR+2WZYTcYv/bz50vKuCPjxJGUIjwRMDmqadI6uNEFkBz99PIOgLXXtLyHdaDCXpX5m+wVFSfk6t/4bKVjfs+v3mBmFa3sE/7CE1tyOTy6ow77vFpzRgND2q3B1103hhx/pmp/IMs5Z7MQMvOeunFaxPq97JPKXorAoQ4IpVcC7HtXyK2i/+3IE3aAeGOP9ixl2c8At4peVMpfDn0aCUWRV+V1fzOu83Cs3/AUBELjDb4A+p0v0a2DzO/XKmesX+E0qdxjtlqww==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuNN5Xsm5V2t8jdqc1464X6IJZt1tsqeNB7XDP/BdVQ=; b=Eq58nvMjj+xqoljhFq+zdg9vuD3T2euTzvt7zocBxZDLy3RHvHZ/4b4hoyITCluvl4uJCd+aixuYB/YU2ao8Zmb/EeI3F5HWcom1pmnjmAnuz91Lxw5xMIIHnnbQitMT5MQkbL1rIym+4AMHMH3/G0igcVnCGewywl+PzeDxTwAqGsky7OJPzYuK1CMb6qEk0qw5rkcctLXubbFKSTEIcCV0peAIRPbmB616aQ/0cVrgRbeprnwuNNCk2Nfr/vRlij7Fa1u0Ta4ixGSVAjBJylnKn25AaQZj2DFdBwcK46uq3CcYk85KNlVRGfAAb6Nd6oBs2deWyK5K038/rhrGqA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=oDd0Ipkin1t98ruPPWTiYOrUj2Xwd+k22nalRPrUz1WvKCxvibNWnPl0PLufAZoMvEUtFz7ru8YA4bkFfKqtekUifPFhT1whT9xX0+WpLzWyDKA4NLvw7I2OsnP+F+mSGtWwWH1zFh1q8fUgHADNZqX4rqL//e6DmkDo31v861JABbCK9zGqChgkCwO2nI7Hmcb9OEoEOQS4+f2MLzfqISR3e5CeEv3fdkA+fs0rTKQdvpvJcbjmoMYYst600bfRJ7lZWtpOHE4D1wJ2T/rHZKHrSm3JH3doip7YQemg2buUexPEJBdWN/VF8RUcX9Dczw7yglxtMMtBubJnGRLDLA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BE/Goq9Y45f9JgebPQF5enpDTlwFCAXun52Ak/orB82GQ0lEXmt0u1ZViB55fVAzR6YzIY7jNMRQ0PDtSuWVaZT04jUy950raM3y9G2WrtCxS2xTO7Vl/n/adjr1A88uv+Ahj58f/BpGa1IyvoSc9AreYxzjtMYq2wPxb4LBm4XivKfPGN5WTLrvHltVaWTCdoKE90WGJunZ1nhjuoANth/hdXR9xVhB/4ILnCAL83qeT6OJ0TpmqBEPB1l8erUtrcZLjaC21onrTIM/oLLKcWNhjwoxgK807pKcQ3dPW0z7KNbWfuLLn7fJiQq3z9ps2ouiURLMh8vLt0xhUomLpw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 10 Apr 2026 14:29:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcyPZFD1i896tq5E+b8JqjtvKuVw==
- Thread-topic: [PATCH v3 07/23] xen/arm: vIOMMU: Add cmdline boot option "viommu = <string>"
HI Milan,
>
> diff --git a/xen/arch/arm/include/asm/viommu.h
> b/xen/arch/arm/include/asm/viommu.h
> index 2a6742de73..ed338fe0ec 100644
> --- a/xen/arch/arm/include/asm/viommu.h
> +++ b/xen/arch/arm/include/asm/viommu.h
> @@ -10,6 +10,7 @@
> #include <public/xen.h>
>
> extern struct list_head host_iommu_list;
> +extern char viommu[];
As far as I can see this one is used only in this header by ...
>
> /* data structure for each hardware IOMMU */
> struct host_iommu {
> @@ -50,6 +51,12 @@ uint16_t viommu_get_type(void);
> void add_to_host_iommu_list(paddr_t addr, paddr_t size,
> const struct dt_device_node *node);
>
> +static always_inline bool is_viommu_enabled(void)
> +{
> + /* only smmuv3 emulation supported */
> + return !strcmp(viommu, "smmuv3");
> +}
this function, it seems cleaner to me if viommu is static inside
xen/xen/drivers/passthrough/arm/viommu.c
and this one can be defined there as well, so here we will have only the
declaration.
Cheers,
Luca
|
