[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 01/23] xen/arm: smmuv3: Maintain a SID->device structure


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Milan Djokic <milan_djokic@xxxxxxxx>
  • Date: Sun, 19 Apr 2026 19:29:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtTykqEOeQLfkooX46gCFuKoex9ftn19RXS6tLDgz/o=; b=oVwesZyK0rNjoKvOij9TL1vodpW9ulZfSE/UXz/5uRy85yDvKa07qPJGNC124K1WmKy5hIRFPGeADXeTrBt6DgnJQl3SaVQjITmEZm8f9Ll71cN6n4QGOv0g2oT1Pq7hjjb9HDBd0MYXOO1+dqdCki3dVXxbUOPKC7wHVOX6GTHV+XggSp8OqNNlIcJfHcZq8Hdk4zOzmPsUXPPCGevOJukU52CG2w4opEjej4t0CLA5zOwKpzgu/9lo/VJOOAKFu0fdwx3GFaC59ZNB87rbwzRK+4HEpgareWBTzbMFNI1JBcIVbhNd2p5fz5+b/wVmNNC8iNm3QNvkFNnj64CBTQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fEOIXXZZcIgqM2hbT4eETdSPwfs3MbBET2sMGCiygZoxxXWT9Z9mYyKgNDRypkeBzfweMgN0pjDrmpwxEKORnl4jkyV04aQz3ytqNE7vhTYyhGGUx1zbDE9zbpRG0uyn1zgfE9gT3VIbYMieb2MryCZnFZyG6ohxVeteUoke4WXuS2uPJaK/7Lap3pf+Wn/N5OBk26OZFJQmDoMLDrAHq1F+HT90GOkM396rPdC2q/iNJfcDnOJCicjPdFCzKUxejNWDlQLi52J3yxSDJ+POrznuPdEnvlA1D9B2NdO6MvAkMTTxfg05xdc/vCcQvdsX4qSvtXLOk4rxuTqilVJ8+w==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, Keqian Zhu <zhukeqian1@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Joerg Roedel <jroedel@xxxxxxx>
  • Delivery-date: Sun, 19 Apr 2026 17:30:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Luca,

On 4/9/26 16:59, Luca Fancellu wrote:
Hi Milan,

On 31 Mar 2026, at 02:51, Milan Djokic <milan_djokic@xxxxxxxx> wrote:

From: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>

Backport Linux commit cdf315f907d4. This is the clean backport without
any changes.

When handling faults from the event or PRI queue, we need to find the
struct device associated with a SID. Add a rb_tree to keep track of
SIDs.

Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx>
Reviewed-by: Keqian Zhu <zhukeqian1@xxxxxxxxxx>
Signed-off-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
Acked-by: Will Deacon <will@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20210401154718.307519-8-jean-philippe@xxxxxxxxxx
Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
cdf315f907d4
Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
Signed-off-by: Milan Djokic <milan_djokic@xxxxxxxx>
---

I think that by only backporting this one we are introducing a regression for 
which
we don’t allow anymore duplicated stream id, have a look on this linux commit
that is fixing it: b00d24997a11c10d3e420614f0873b83ce358a34.


I will backport the logic from this commit also

P.s. I was able to apply only until patch 3, I think this serie needs a rebase, 
do you have
an updated branch or can you point me to the staging SHA to build it? (hope 
it’s not too far
from now)


Yes, sorry for that, it's conflicting with the couple of recently merged commits, rebased for the new version.

Cheers,
Luca



Best regards,
Milan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.