[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 01/13] xen/arm: Add suspend and resume timer helpers
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 20 Apr 2026 15:22:38 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7X01osOk7vgacygI5pbFYogajfSTTELKFBntgHZvOA=; b=XiGzHPaMVVEqfmeMv3snAQBTS0U6A5j62xPsDgJLLxjoQztuEGQ3qb8KTt2vNy9uLsPgP7r8PohwOD6LC3hL/W323K5Pz4Drzt35hmKsDrFSeB63eLFVk2D2XsyT85O9By86oE/WxfaX71jkQOwRi0y0iETxdOm7iQISBNuzMO4OUPGc8ore7d6HlyY8VHkRdItBeLuJFR5DeItkrT9ZRGKk2PhJTJLWoCWg5Ds/6sEwD+JvyLX1gXPNlZ4Uw7x0V0zj6b9ROdLJ6m4FS2tJN1rVE/V3laAZd/p1jrw1EME+uPaEKUeEalUW0kNMFXuM5xBmJWc9eecPA8ubtdP9cg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7X01osOk7vgacygI5pbFYogajfSTTELKFBntgHZvOA=; b=ZDiyCYZ4v7yOjqIFXn96fmKd0AvJ/VA0j9xV+v2WxexJ+smn2xk9ffvfiKeEnTiH0c1G08xQ2g8IBViQpdS5u0CEcDw/fTXaRzxv7/QwxK6kZf7CzB5FvLX6EgcBTi9nPklzCQ0wf4SNw9dyNd1MbZRq1OEZbaSGHHyHJOfrbVeNEmXY9vN3pljWX5wQti+1NqAlTkvp/tP5mC3MzL6jYbDe59kUZefYwhKrE5QTPvTx4QZ9td4jMLfwFQL8Q7afe/UoV7cxxJc5+Swn9FY/xws2bGh8vDvhwvO4drMVjUREeExw1+OXnlFUIgfMR1xXE/1gq2DO+B1EHlvMHKzfhQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=nl0Wp89vzEFJkBYYGwZl4LGqa82g8tILUWv4gra5qwzW/Jv6zwBAwcPpWuuGCbzdaSUyQWJPY7ovor5vfCkaSxXNTorvd/rHnqvprrqitjHcBpMjAIy/KpKtSgURH39D1u72svZZAs1awkJ38WWHkO1vLCM79pIGJNiYXRlOtQksqei4/v69tzQb9UvN98c+tJphNsstYF3nXMx0ygr72lPU2dHg4n2bZ0fyxq0WNLUSuoV7GiA/03amIMAlg/XGbZSeSMpIU2oxhXd7tgvgK9zrkuCdzJo7RsT/IdTuKOi29zRWLDw9WNfZeq/rejLNwgbsoYqSFVOjamH13EYksQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xeRmUS9TbOlGyVR9eE0YuCnW2zbEV/ADZsSpTKNOpmXQqO5pA8wFSWBal+uFSYG/vJiD4y9RWsJitLQ1s//5A3Ud2iXrgRjc76EkTlQBzYSJGy+KrBox67W+f3gNpbFUJ5ofpBo1R8I2TGKTFgYyeNlkGiX5mh3mqI0ybmLG2xDpWhK7hlySRSzDThxaESchTR4d5FtfzgmUdnE8xdQYkzEfOmQU0O4jCgYOpaRjMBUS7d9PQZTShBxlKkZ5Had8cN2aV6AN1/Qk9Ew7OBXiOmH/a0ZCTgBV6yutIVA6wkPi1hYAUNzxPP/m7z5FD9Ej1D39qNMvX1ksOyfFCpCLbA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Mon, 20 Apr 2026 15:23:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc0NmFet8mB9OE3kGEFwtr0PnQig==
- Thread-topic: [PATCH v8 01/13] xen/arm: Add suspend and resume timer helpers
Hi Mykola,
> On 2 Apr 2026, at 11:45, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
>
> Timer interrupts must be disabled while the system is suspended to prevent
> spurious wake-ups. Suspending timers in Xen consists of disabling the
> physical timer and the hypervisor timer on the current CPU. The virtual
> timer does not need explicit handling here, as it is already disabled on
> vCPU context switch and its state is restored per-vCPU on the next context
> restore.
>
> Resuming consists of raising TIMER_SOFTIRQ, which prompts the generic
> timer code to reprogram the hypervisor timer with the correct timeout.
>
> Xen does not use or expose the physical timer, so it remains disabled
> across suspend/resume.
>
> Introduce a new helper, disable_phys_hyp_timers(), to encapsulate disabling
> of the physical and hypervisor timers.
>
> Signed-off-by: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
> Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xxxxxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
>
Changes looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
