[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC PATCH v6 33/43] arm/altp2m: Add altp2m_set_view_visibility{,_locked} support


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Rose Spangler <Rose.Spangler@xxxxxxxxxxxxxx>
  • Date: Mon, 20 Apr 2026 17:31:56 -0400
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 40.93.13.101) smtp.rcpttodomain=amd.com smtp.mailfrom=elektrobit.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=elektrobit.com; dkim=pass (signature was verified) header.d=elektrobit.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=elektrobit.com] dmarc=[1,1,header.from=elektrobit.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 213.95.148.172) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=elektrobit.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=elektrobit.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u057BdoXIkdDPBzf9f3VOEcMsy8wtSGiXp7V2fStTSo=; b=kn4B0U8snqaHA+dlRIERnHp2Rn4mvgd20XFU9Ge6MbtQmJueqU5wEJHYRjXSUAuMbsUWelpdepjSlMaqKSMUcvviePzDGkJW3a4V7ckCeThCm+nPYHK508kg8Bz3zNi0rscSbzRmI8key4qCCVTHKgS7TsqGCtvCL8LSPVeA+zqNhxkJo2f7zNsBZNT84L09TY6VEAB2YLAcFXtXVJcv9lzuFkVnWQG8X8fFwIZvLR1/OtWz8mdq3cqOxEe/mPsQE8PjHs0gdbB+JRnVJdgMEACB51O6Y3OYuWcLCJk08R1OVjZux3v+L5EiK3cy4yhOoARlczlb6EhISFvPht9Pwg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u057BdoXIkdDPBzf9f3VOEcMsy8wtSGiXp7V2fStTSo=; b=cewLUSbQqc232dKEHvYMmbwSSacMDEeCCSjMo7ulCkRPs828RWJg+PdhjFZpZ/KiKSDDR+bGjXPH1d2xpgllTODsVT9IHmybldPfTvgX/SQg+EYux7Z5fRgIX+2pv7f/jubXpr/Hq8sV5chS6H2eIG+ej5K+SVV2SHDMnn9Nj/FFlTw+WIy7S0yYUO1pDIcztOTvE3oECt6O4BsagTqrRF8YO6g4VBpr7ov4BAwPbH88JI0Iw/0lBUsR64rBnL84No57SLtKS15C40elmcpL3HJnLQUsSz3StVKZLMwQjVahmqJgi0lMK12w+vaNUj8/oXZO6KqRqQVqfEKy0tB6ew==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=VZ/IFfy3AVMQT5J69G8IdO3rqcWYtkW5osvNRNE9n6nSSeDsJ3uXiZ6cm6YQ6uxERBxYYKUNNdVHRq21sU7e5ziVxTvGtDkCQLQ5yopliRYtw0v1U/t1bUGUFFxXS6gkETvGbYEY2+bGpSwzbF415dvHzAfwaJR5ivyTThs+1rgcqcDW1BHTE9/FnB9OVoeP699yG6gocUb9KecOlQBVDUndYN2o9Rk/ip+W04+hdfMWRnXBgo6W7Cbwma+X4i1BOW6SxmnTe1CSTLlZRqYphgF/+wwIzVCvJXN2WcYLyekON3zBQvXKWxrg+0+AESaq4rjn0Lw11sJEYWoV3mylRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZdL0n1c4jXKWI/a1Li9ufiu4B+MKjzXoO2rHUbuR0itwPIN19N6wwK9CMEUnK2sff8KnEIs7FncRZnpOnJ1hKt7LtkwWnkAKR5eYvkwnFBmcvOdgtXikEFmnMWXqgsU4KDSDciM4EYS3EQzqimAVOgQSgy808z8ghcJ9p9TCicLqQatEleEch5bKULaZdfLBZKIgX7vyNhgr3L36wXJCUD99Dt+kwOYnJr9p9WbOpLLKlXXA24gSyZRMNyBxNCQ56k94R1FGNU+F/i/qAXVat26DTyrP1WTcGF/jV1ykmVm9ItT9tzlnI3oRz0LtRzGfrwBKQEL1t3FfUpfThR9LNg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Rose Spangler <Rose.Spangler@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 20 Apr 2026 21:33:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This commit adds the altp2m_set_view_visibility and
altp2m_set_view_visibility_locked functions on ARM. This makes it possible
to set the altp2m view visibility in common altp2m routines (namely,
altp2m_flush).

This is commit 4/5 of the altp2m view validity/visibility phase.

Signed-off-by: Rose Spangler <Rose.Spangler@xxxxxxxxxxxxxx>
---
v6: Introduced this patch.
---
 xen/arch/arm/altp2m.c             | 30 ++++++++++++++++++++++++++++++
 xen/arch/arm/include/asm/altp2m.h |  8 ++++++++
 2 files changed, 38 insertions(+)

diff --git a/xen/arch/arm/altp2m.c b/xen/arch/arm/altp2m.c
index 0e19e197e826..aa48c17e11a3 100644
--- a/xen/arch/arm/altp2m.c
+++ b/xen/arch/arm/altp2m.c
@@ -37,6 +37,36 @@ bool altp2m_view_is_visible(struct domain *d, unsigned int 
idx)
     return d->arch.altp2m_state[array_index_nospec(idx, d->nr_altp2m)] == 
ALTP2M_VISIBLE;
 }
 
+int altp2m_set_view_visibility(struct domain *d, unsigned int altp2m_idx,
+                               uint8_t visible)
+{
+    int rc;
+
+    altp2m_lock(d);
+    rc = altp2m_set_view_visibility_locked(d, altp2m_idx, visible);
+    altp2m_unlock(d);
+
+    return rc;
+}
+
+int altp2m_set_view_visibility_locked(struct domain *d, unsigned int 
altp2m_idx,
+                                      uint8_t visible)
+{
+    int rc = 0;
+
+    if ( altp2m_idx >= d->nr_altp2m || !altp2m_view_is_valid(d, altp2m_idx) )
+        rc = -EINVAL;
+    else if ( visible )
+        d->arch.altp2m_state[array_index_nospec(altp2m_idx, d->nr_altp2m)] =
+            ALTP2M_VISIBLE;
+    else
+        d->arch.altp2m_state[array_index_nospec(altp2m_idx, d->nr_altp2m)] =
+            ALTP2M_INVISIBLE;
+
+    return rc;
+}
+
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/include/asm/altp2m.h 
b/xen/arch/arm/include/asm/altp2m.h
index fbe66ad5536d..f8d0dd799a4a 100644
--- a/xen/arch/arm/include/asm/altp2m.h
+++ b/xen/arch/arm/include/asm/altp2m.h
@@ -40,6 +40,14 @@ enum altp2m_view_state {
     ALTP2M_INVISIBLE,
 };
 
+/* Set a specific p2m view visibility */
+int altp2m_set_view_visibility(struct domain *d, unsigned int altp2m_idx,
+                               uint8_t visible);
+
+/* Set a specific p2m view visibility (with lock already held) */
+int altp2m_set_view_visibility_locked(struct domain *d, unsigned int 
altp2m_idx,
+                                      uint8_t visible);
+
 #else /* CONFIG_ALTP2M */
 
 static inline bool altp2m_supported(void)
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.