[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/8] tools/xenstored: expand special watch handling with depth feature


  • To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 20 Apr 2026 18:55:56 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QnZjx5wyPP3o8YwyK/kvZqix0T4Ac0UZ5dpsNMO9/KU=; b=nS0/jsiJ1D80rWckZTU0ntwpnh0AejEYnarPAYzOj1zQTgolh7ZDKxv/6iwaH1/K+NM4KDy2desHSFBhm6UCcH3qtXLwa0lsP8tjRfjcSYSPOOzoEOEbnb3kSF2EgZOk0FHxuLFmeIbSyWckWj3hsx6lLPOCFp7UTjUn6qq35YDd4evcBHSGVE0UNLf5TYfeaeklvde81dCdfQsAYPEr6OTR/Cb6eQpnPFNC1zvUkqSkrBQLqFmFALilFNkeuu3h8VRaF4gzF/hxXRR3+MhQRKLGhNe3R2GdV6MNT+pm9ievNZZR6Yd7qsjDZ5ZQZY0vl2Yv40hO8N7TPHy0d3fEjg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ue8RVeraOTZnhGArymj+um+5g+Oe0TeBkNZi3ltEKbUXawH+DQLGQI+2vBM7qbgI2LmUiCmduUeL3CSeOFI4+t/TLPSgfM5CCVD18+iu5ZLDTCMju9ofYw/+gUx0xtRYlBLtbhhWaRFvBC35wO557RiW07QK63aBjpv4RpDWBml/Roj/eFk7TSbxqQQtM4Vc/yziPdIiCV/vOtLFn24pMs8w8H6I3trfD73y4DcI4N2OZ/BtC36dQSIhg8iLUKjS4zh2QfTIJnPp5Y4uDDYqvW5+0gZN8R6cFratx/wvNkokoSk4V+5ifVqGRHWptTB387PlCwFWQdjk/xJSX+efng==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Mon, 20 Apr 2026 23:51:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-03-13 03:47, Juergen Gross wrote:
With XENSTORE_SERVER_FEATURE_WATCHDEPTH available, special watch
handling needs to be extended:

- when a special watch is set with depth = 1, the domid is added to
   the watch event

- it is possible to watch for @releaseDomain/<domid>

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

@@ -678,10 +693,13 @@ static int do_check_domain(struct domain *domain, bool 
*notify,
                if ((state & XENMANAGE_GETDOMSTATE_STATE_SHUTDOWN)
                    && !domain->shutdown) {
                        domain->shutdown = true;
+                       fire_special_watches("@releaseDomain", domain->domid,
+                                            WATCH_DOM);
                        *notify = true;
                }
-               if (!(state & XENMANAGE_GETDOMSTATE_STATE_DEAD))
+               if (!(state & XENMANAGE_GETDOMSTATE_STATE_DEAD)) {
                        return 0;
+               }

Stray  {} addition?

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

        }
        if (domain->conn) {
                /* domain is a talloc child of domain->conn. */



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.