[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/9] tools/libs/store: add support to use watches with a depth parameter
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 21 Apr 2026 09:54:46 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRyuYiYcK7B3hZM900kyl7tC80qmQh7ZvMisYRDPC2M=; b=VGhn21B4CL12zIKGLF+Db/8ovlp9XoM877+nabSdvJcrzNUTeh0yQYdURzt5elR636/KjHFjXOdfKyco/Fdxrh7HQydCcxceW+qTGHSKNpd241x/iE58GvHVIV/hiPvLCdBsSGL3a0piu+2lh/W/ZU4V17inAOST48HQO9LUlVNg+OBCCJSpV7QWQnWY7d5wIMOnQnvUlbFpI51R6D/HfnwGPRbL5GSvzhqYEB1dh0TX2SW8UyHQ3S0wkG5/mnoNZI5He8HkoZmR+3l26HDskC+QWKFa6e2hdiBTMR1jvQAh2vZcAghjm29Xl6b6o4n8NJC7kBK2ACB+g0643smirA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=do651v2B7k03aYhERZ+XUILETVfNgFws8TRFJ4gHc6p+N2fZAjW7c9MZ+vKjbXtmkJmpulmY2R4Qm2rVDWlv0NH9h4ml0yZGrNEptYX62mndohait9e6XClGhRjF7s3JaL/S3Sjz89jjwVMqQoL75gRiAijSRuSD25923tKY3/mxqNEZeCCpOIiKMuMcGk7Z9QOOyFI/Lgf8kNla2V164874Tgh3xHg4vlsbMNpfmhOUFXOe7cEy59CcOj9aLh+Vkow7OCXFeLIJp8qSUbgOI24aW2H1WS3m0vD4YwLjcDuYD5MDE8tdYXtvlDx1FenNoHGZTKobP7fuhOUdJbHKcQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Tue, 21 Apr 2026 13:55:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-04-21 03:42, Juergen Gross wrote:
Add a new xs_watch_depth() function to libxenstore allowing to limit
the scope of a Xenstore watch. It can be used only in case Xenstore is
supporting the XENSTORE_SERVER_FEATURE_WATCHDEPTH feature.
For convenience add a xs_watch_try_depth() wrapper, which will call
xs_watch_depth() if supported and xs_watch() otherwise.
Cache the supported features of Xenstore in order not having to get
them from Xenstore for each call of one of the new functions.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c
index 06462445e0..cb3508a86a 100644
--- a/tools/libs/store/xs.c
+++ b/tools/libs/store/xs.c
@@ -1001,8 +993,8 @@ bool xs_watch(struct xs_handle *h, const char *path, const
char *token)
# define PTHREAD_STACK_MIN 0
#endif
-#define READ_THREAD_STACKSIZE \
- ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ? \
+#define READ_THREAD_STACKSIZE \
+ ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ? \
This is an unrelated whitespace change, and not mentioned in the commit
message. It should probably be dropped since the surrounding lines are
no longer touched. Alternatively kept and mentioned. With either of those:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
Jason
PTHREAD_STACK_MIN : DEFAULT_THREAD_STACKSIZE)
/* We dynamically create a reader thread on demand. */
|
