[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/riscv: fix sstc init to write vstimecmp instead of stimecmp





On 5/19/26 6:14 PM, Baptiste Le Duc wrote:
According to the comment above initializing of CSR_VSTIMECMP should be used 
instead of CSR_STIMECM.

Probably, it is something wrong with my e-mail app but this line looks long enough.

I think we have to follow 80 chars per line.

Nit: s/CSR_STIMECM/CSR_STIMECMP


Fixes: 25e032730690 ("xen/riscv: allow Xen to use SSTC while hiding it from 
guests")

Nit: there is no need for empty line between Fixes: and Signed-off-by.


Signed-off-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>

Nit: it also would be nice to put here what was changed, for example,
---
Changes in v2:
 - Update the commit message.
---

Please don't rush to send a new version of the patch. Probably committers will agree to make suggested fixes during commit.

With fixes mentioned above:
 Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks!

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.