[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/3] xen/libfdt: fix UBSAN null pointer in fdt_property()


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Wed, 20 May 2026 09:56:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IR6+fktXwIXkaRDI+OMF+BgDVBMQl7kRoFmawKgfKDM=; b=jIRG9ou8Ly7lFseQjY7fL8RHGDXs4P15O7hjEZwy/a/QxPv6cczWYiKniaNIjzHnS7u3R1g1QwewMn7cgYzly+JXfYeb4OXhHnumy9xk3vjE84f9KiryKC5lNI86lLrboNlBQMihBxtJ9PDNOQA/vQ5xMuFmve7JUt9jtnopPCmFrJ8B0yWeQQmBc1Os5MO5IozVZWf5vq1GU7bYFNTCqJm3t7lFW/3rafxxSlGWo8QswVhqfFFtNa5V56U1Bymk62qwWrUY1jpJvOOZQfV6TR74Vj5MObjLuYh8AoP97oX46G2zOVDbjCcRBaG+zuuG1ElJUmRVLBi7tR6FbxCrFQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fgszy4I78oOtQRf254wGTcRQ0oWkElpcQnhmuEUyDzZKVBiE2yaRecwreZoDtzpZ4iqasc4/WTWI8TnsbUU5fPKmjhWAN+rj4boGg7rOYusB5MMZRE/G809H+1n4IW/dI6qybKt+56I/bwiulvFaAoEoe14hSQOOcKpkQwk1Id6L4hKQxmKvvanrAIZQm4lYrKYJLo3KLGc1cw1eVIaXMOwnIWvlprgr07+rZQln/aJa37riy33awg1x1y2GXpPwS/bXcwJCuqxFb/YQryZ9jobuIM20lq354Z5sV0JrGRIF7CN96YxXQREv3TkQdOMpwe1pHzVzxIEgeAPb1FF7+g==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Wed, 20 May 2026 07:56:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 20-May-26 09:51, Oleksii Kurochko wrote:
> Hello Michal,
> 
> On 5/19/26 11:37 AM, Orzel, Michal wrote:
>>>> We treat libfdt as external library and we don't accept any edits here 
>>>> prior to
>>>> first sending a fix to libfdt and then cherry-picking a patch (in fact, 
>>>> afacit
>>>> we then do the libfdt version update).
>>>
>>> Thanks for clarifying that.
>>>
>>> Just to be sure I don't confuse something.
>>> According to the commit ...:
>>>
>>> commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
>>> Author: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
>>> Date:   Thu Nov 11 23:27:20 2021 -0800
>>>
>>>       Update libfdt to v1.6.1
>>>
>>>       Update libfdt to v1.6.1 of libfdt taken from
>>> git://github.com/dgibson/dtc.
>>>       This update is done to support device tree overlays.
>>>
>>> ... I have to send this patch to git://github.com/dgibson/dtc, right?
>> Yes, that's the main DTC/libfdt repository.
> 
> The patch to dtc repo was accepted and merged:
> https://github.com/dgibson/dtc/commit/f57e7df35df4a301961cbbf9433ba4e85c2ee5ed
> 
> But current version of dtc is:
>    $ cat https://github.com/dgibson/dtc/blob/main/VERSION.txt
>      1.7.2
> 
> Does it make sense to backport just one patch to Xen instead of updating 
We can backport this patch only the same way as for example here:
d434dc4ac182 ("libfdt: overlay: change overlay_get_target()")

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.