Re: [PATCH] xen/arm: gic-v3: Fix redistributor wakeup polling

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 5/21/26 9:06 AM, Orzel, Michal wrote:
> Oleksii, can we ask for a release ack for this fix?
>
> ~Michal
>
> On 19-May-26 09:19, Orzel, Michal wrote:
> > On 18-May-26 09:05, Luca Fancellu wrote:
> > > gicv3_enable_redist() clears GICR_WAKER.ProcessorSleep and then waits for
> > > GICR_WAKER.ChildrenAsleep to clear, as required after waking a
> > > redistributor.
> > >
> > > However, the polling loop currently uses "while ( timeout )". Since
> > > timeout is initially false, the loop runs only once unless the timeout
> > > path has already been reached. As a result, Xen can continue before the
> > > redistributor has completed wakeup.
> > >
> > > Use an unconditional loop, matching the surrounding timeout/break pattern,
> > > so the code polls until either ChildrenAsleep is clear or the deadline is
> > > reached.
> > >
> > > While there, also fix the timeout message. This path polls
> > > GICR_WAKER.ChildrenAsleep, not an RWP bit, so "RWP timeout" is misleading.
> > >
> > > Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
> > > Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks.

~ Oleksii