Re: [PATCH v2 11/26] xen/riscv: introduce aia_init() and aia_usable()

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 5/21/26 4:57 PM, Jan Beulich wrote:
> On 08.05.2026 16:43, Oleksii Kurochko wrote:
> > aia_init() is going to contain all the logic related to AIA initialization.
> >
> > At the moment, it only checks whether the SSAIA extension is available,
> > and if so, sets is_aia_usable (which  indicates more than just the
> > availability of the extension) to true; it also signifies that the necessary
> > components (to be introduced in follow-up patches) have been initialized.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.

> albeit again with a comment for consideration:
>
> > --- /dev/null
> > +++ b/xen/arch/riscv/aia.c
> > @@ -0,0 +1,23 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +
> > +#include <xen/errno.h>
> > +#include <xen/init.h>
> > +#include <xen/sections.h>
> > +#include <xen/types.h>
> > +
> > +#include <asm/cpufeature.h>
> > +
> > +static bool __ro_after_init is_aia_usable;
> While in an if() the is_ prefix may make sense, in most other uses (all
> of the ones below, imo) it is of questionable value. I'd suggest to drop
> it, but of course with the then leading underscore retained, to ...
>
> > +bool aia_usable(void)
> > +{
> > +    return is_aia_usable;
> > +}
> ... not conflict with this function.
IIUC then I am okay with the following changes:

-static bool __ro_after_init is_aia_usable;
+static bool __ro_after_init _aia_usable;

 bool aia_usable(void)
 {
-    return is_aia_usable;
+    return _aia_usable;
 }

 void __init aia_init(void)
@@ -19,5 +19,5 @@ void __init aia_init(void)
     if ( !riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ssaia) )
         return;

-    is_aia_usable = true;
+    _aia_usable = true;
 }

~ Oleksii