Re: [PATCH 1/2] argo: lower level of noisy connection-refused log

[dmukhin@xxxxxxxx]

On Fri, May 22, 2026 at 09:53:18AM +0300, Mykola Kvach wrote:
> Hi Denis,
> 
> Thank you for the contribution.
> 
> On Fri, May 22, 2026 at 2:57 AM <dmukhin@xxxxxxxx> wrote:
> >
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Lower the log level of the "connection refused" log line, as it can
> > spam the logs when a dom0 service using the Argo hypercall tries to
> > communicate with a domain that is still starting up.
> >
> > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> > ---
> >  xen/common/argo.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/xen/common/argo.c b/xen/common/argo.c
> > index 28626e00a8cb..4f894470698e 100644
> > --- a/xen/common/argo.c
> > +++ b/xen/common/argo.c
> > @@ -2034,10 +2034,9 @@ sendv(struct domain *src_d, xen_argo_addr_t 
> > *src_addr,
> >                                          src_id.domain_id);
> >      if ( !ring_info )
> >      {
> > -        gprintk(XENLOG_ERR,
> > -                "argo: vm%u connection refused, src (vm%u:%x) dst 
> > (vm%u:%x)\n",
> > -                current->domain->domain_id, src_id.domain_id, src_id.aport,
> > -                dst_addr->domain_id, dst_addr->aport);
> > +        argo_dprintk("argo: vm%u connection refused, src (vm%u:%x) dst 
> > (vm%u:%x)\n",
> 
> AFAIU, argo_dprintk() already adds the "argo: " prefix internally.

Thanks!
Will fix this and the follow on patch too.

> 
> Best regards,
> Mykola
>