[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 08/21] xen/sched: Link CPU topology to scheduler and display via xl info



Hello,

> > --- a/xen/include/xen/cpu_topology.h
> > +++ b/xen/include/xen/cpu_topology.h
> > @@ -14,6 +14,9 @@ struct cpu_topology {
> >      cpumask_t thread_sibling;
> >      cpumask_t core_sibling;
> >      cpumask_t cluster_sibling;
> > +    int to_core;
> > +    int to_socket;
> > +    int num_siblings;
> >  };
> 
> What significance do the to_ prefixes have here? And what's the meaning of any
> of the fields holding negative values? (If they can't hold negative values, 
> use
> unsigned int please.)

These members are used to map a logical CPU ID to a physical core ID and
a physical socket ID. I will rename them to phys_core_id and phys_socket_id
respectively, and make them unsigned int.

Thank you for your advice.
Hirokazu Takahashi

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.