Re: [PATCH v2] Fix fallout from DOMID_ANY ABI breakage

[Pau Ruiz Safont <pau.safont@xxxxxxxxxx>]

On 28/05/2026 12:39, Andrew Cooper wrote:
> ---
>   CHANGELOG.md                         | 4 ++++
>   tools/helpers/init-xenstore-domain.c | 2 +-
>   tools/ocaml/libs/xc/xenctrl.ml       | 4 +++-
>   tools/python/xen/lowlevel/xc/xc.c    | 2 +-
>   4 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 25f5a192ed48..1db3efc4864c 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -7,6 +7,10 @@ The format is based on [Keep a 
> Changelog](https://keepachangelog.com/en/1.0.0/)
>   ## [4.22.0 
> UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging)
>  - TBD
>   
>   ### Changed
> + - Users of XEN_DOMCTL_createdomain/xc_domain_create() must now pass 
> DOMID_ANY
> +   to obtain an automatically allocated domid.  The prior sentinel values (0
> +   since the start of Xen, and DOMID_INVALID since Xen 4.21) now no longer
> +   represent a wildcard input.
>    - On x86:
>      - Enable pf-fixup option by default for PVH dom0.
>   
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 97108b9d861a..147afa62c293 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -208,7 +208,9 @@ let with_intf f =
>   external domain_create_stub: handle -> domid -> domctl_create_config -> 
> domid
>     = "stub_xc_domain_create"
>   
> -let domain_create handle ?(domid=0) config =
> +let domid_any = 0x7ff5 (* DOMID_ANY from public/xen.h *)
> +
> +let domain_create handle ?(domid=domid_any) config =
>     domain_create_stub handle domid config
>   
>   external domain_sethandle: handle -> domid -> string -> unit
> base-commit: e63ba93511b33c0d3bb8cc5870f946f41e1d2655

Acked-by: Pau Ruiz Safont <pau.safont@xxxxxxxxxx>

Regards,
Pau



--
Pau Ruiz Safont | Vates XAPI Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech